Title: [132409] trunk/Source/WebCore
- Revision
- 132409
- Author
- simon.fra...@apple.com
- Date
- 2012-10-24 15:01:03 -0700 (Wed, 24 Oct 2012)
Log Message
Null-check the RenderView in ocument::windowScreenDidChange to fix a crash when saving PDFs
https://bugs.webkit.org/show_bug.cgi?id=100141
<rdar://problem/12559147>
Reviewed by Tim Horton.
For PDF documents the RenderView is null, so null-check it to avoid a crash
when saving PDFs.
* dom/Document.cpp:
(WebCore::Document::windowScreenDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (132408 => 132409)
--- trunk/Source/WebCore/ChangeLog 2012-10-24 22:00:32 UTC (rev 132408)
+++ trunk/Source/WebCore/ChangeLog 2012-10-24 22:01:03 UTC (rev 132409)
@@ -1,3 +1,17 @@
+2012-10-24 Simon Fraser <simon.fra...@apple.com>
+
+ Null-check the RenderView in ocument::windowScreenDidChange to fix a crash when saving PDFs
+ https://bugs.webkit.org/show_bug.cgi?id=100141
+ <rdar://problem/12559147>
+
+ Reviewed by Tim Horton.
+
+ For PDF documents the RenderView is null, so null-check it to avoid a crash
+ when saving PDFs.
+
+ * dom/Document.cpp:
+ (WebCore::Document::windowScreenDidChange):
+
2012-10-24 Terry Anderson <tdander...@chromium.org>
Handle two-finger tap gestures in the same way as long-press gestures
Modified: trunk/Source/WebCore/dom/Document.cpp (132408 => 132409)
--- trunk/Source/WebCore/dom/Document.cpp 2012-10-24 22:00:32 UTC (rev 132408)
+++ trunk/Source/WebCore/dom/Document.cpp 2012-10-24 22:01:03 UTC (rev 132409)
@@ -4977,8 +4977,10 @@
#endif
#if USE(ACCELERATED_COMPOSITING)
- if (renderView()->usesCompositing())
- renderView()->compositor()->windowScreenDidChange(displayID);
+ if (RenderView* view = renderView()) {
+ if (view->usesCompositing())
+ view->compositor()->windowScreenDidChange(displayID);
+ }
#endif
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
