Title: [132474] trunk/Source/WebCore
Revision
132474
Author
apav...@chromium.org
Date
2012-10-25 05:11:00 -0700 (Thu, 25 Oct 2012)

Log Message

Web Inspector: Drag and drop property value from Inspector is not working as expected
https://bugs.webkit.org/show_bug.cgi?id=100040

Reviewed by Vsevolod Vlasov.

Do not start a custom drag for a tree element if there is a non-collapsed selection in the Inspector.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._ondragstart):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (132473 => 132474)


--- trunk/Source/WebCore/ChangeLog	2012-10-25 12:06:08 UTC (rev 132473)
+++ trunk/Source/WebCore/ChangeLog	2012-10-25 12:11:00 UTC (rev 132474)
@@ -1,3 +1,15 @@
+2012-10-23  Alexander Pavlov  <apav...@chromium.org>
+
+        Web Inspector: Drag and drop property value from Inspector is not working as expected
+        https://bugs.webkit.org/show_bug.cgi?id=100040
+
+        Reviewed by Vsevolod Vlasov.
+
+        Do not start a custom drag for a tree element if there is a non-collapsed selection in the Inspector.
+
+        * inspector/front-end/ElementsTreeOutline.js:
+        (WebInspector.ElementsTreeOutline.prototype._ondragstart):
+
 2012-10-25  Ilya Tikhonovsky  <loi...@chromium.org>
 
         Web Inspector: NMI instrument InspectorDebuggerAgent. It uses a lot of memory on heavy js sites because it keeps all the scripts in a map.

Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (132473 => 132474)


--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js	2012-10-25 12:06:08 UTC (rev 132473)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js	2012-10-25 12:11:00 UTC (rev 132474)
@@ -359,6 +359,9 @@
 
     _ondragstart: function(event)
     {
+        if (!getSelection().isCollapsed)
+            return false;
+
         var treeElement = this._treeElementFromEvent(event);
         if (!treeElement)
             return false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to