Title: [133185] trunk/Source/Platform
Revision
133185
Author
wjmacl...@chromium.org
Date
2012-11-01 09:45:41 -0700 (Thu, 01 Nov 2012)

Log Message

[chromium] Make WebLayerTreeView::adjustEventPointForPinchZoom pure virtual.
https://bugs.webkit.org/show_bug.cgi?id=100875

Reviewed by James Robinson.

This CL removes the default implementation for adjustEventPointForPinchZoom(), which
was necessary for landing the original patch in https://bugs.webkit.org/show_bug.cgi?id=100542.

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):

Modified Paths

Diff

Modified: trunk/Source/Platform/ChangeLog (133184 => 133185)


--- trunk/Source/Platform/ChangeLog	2012-11-01 16:24:31 UTC (rev 133184)
+++ trunk/Source/Platform/ChangeLog	2012-11-01 16:45:41 UTC (rev 133185)
@@ -1,3 +1,16 @@
+2012-11-01  W. James MacLean  <wjmacl...@chromium.org>
+
+        [chromium] Make WebLayerTreeView::adjustEventPointForPinchZoom pure virtual.
+        https://bugs.webkit.org/show_bug.cgi?id=100875
+
+        Reviewed by James Robinson.
+
+        This CL removes the default implementation for adjustEventPointForPinchZoom(), which
+        was necessary for landing the original patch in https://bugs.webkit.org/show_bug.cgi?id=100542.
+
+        * chromium/public/WebLayerTreeView.h:
+        (WebLayerTreeView):
+
 2012-10-31  Stephen White  <senorbla...@chromium.org>
 
         Unreviewed, rolling out r133122.

Modified: trunk/Source/Platform/chromium/public/WebLayerTreeView.h (133184 => 133185)


--- trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2012-11-01 16:24:31 UTC (rev 133184)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2012-11-01 16:45:41 UTC (rev 133185)
@@ -96,8 +96,9 @@
     // mode).
     virtual WebSize deviceViewportSize() const = 0;
 
-    // FIXME: Once cc::LayerTreeHost::adjustEventPointForPinchZoom lands, make this pure virtual.
-    virtual WebFloatPoint adjustEventPointForPinchZoom(const WebFloatPoint& point) const { return point; }
+    // Gives the corrected location for an event, accounting for the pinch-zoom transformation
+    // in the compositor.
+    virtual WebFloatPoint adjustEventPointForPinchZoom(const WebFloatPoint&) const = 0;
 
     virtual void setDeviceScaleFactor(float) = 0;
     virtual float deviceScaleFactor() const = 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to