Title: [133399] trunk/Source/WebCore
- Revision
- 133399
- Author
- senorbla...@chromium.org
- Date
- 2012-11-03 13:52:17 -0700 (Sat, 03 Nov 2012)
Log Message
Speculative fix to eliminate flakiness in
css3/filters/blur-filter-page-scroll-self.html
https://bugs.webkit.org/show_bug.cgi?id=91620.
Suspicion is that a prior test is setting
window.internals.settings.setEnableCompositingForFixedPosition(true),
causing this test to be intermittely run on the GPU, giving different
pixel results depending on test order.
Reviewed by Jochen Eisinger.
Covered by css3/filters/blur-filter-page-scroll-self.html
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
(Backup):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (133398 => 133399)
--- trunk/Source/WebCore/ChangeLog 2012-11-03 20:48:08 UTC (rev 133398)
+++ trunk/Source/WebCore/ChangeLog 2012-11-03 20:52:17 UTC (rev 133399)
@@ -1,3 +1,23 @@
+2012-11-03 Stephen White <senorbla...@chromium.org>
+
+ Speculative fix to eliminate flakiness in
+ css3/filters/blur-filter-page-scroll-self.html
+ https://bugs.webkit.org/show_bug.cgi?id=91620.
+ Suspicion is that a prior test is setting
+ window.internals.settings.setEnableCompositingForFixedPosition(true),
+ causing this test to be intermittely run on the GPU, giving different
+ pixel results depending on test order.
+
+ Reviewed by Jochen Eisinger.
+
+ Covered by css3/filters/blur-filter-page-scroll-self.html
+
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::Backup):
+ (WebCore::InternalSettings::Backup::restoreTo):
+ * testing/InternalSettings.h:
+ (Backup):
+
2012-11-03 Mark Rowe <mr...@apple.com>
REGRESSION (r132858): Crash below -[DOMElement setClassName:] when called with a nil string
Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (133398 => 133399)
--- trunk/Source/WebCore/testing/InternalSettings.cpp 2012-11-03 20:48:08 UTC (rev 133398)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2012-11-03 20:52:17 UTC (rev 133399)
@@ -93,6 +93,7 @@
, m_originalDialogElementEnabled(RuntimeEnabledFeatures::dialogElementEnabled())
#endif
, m_canStartMedia(page->canStartMedia())
+ , m_originalCompositingForFixedPositionEnabled(settings->acceleratedCompositingForFixedPositionEnabled())
, m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled())
, m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled())
, m_imagesEnabled(settings->areImagesEnabled())
@@ -135,6 +136,7 @@
RuntimeEnabledFeatures::setDialogElementEnabled(m_originalDialogElementEnabled);
#endif
page->setCanStartMedia(m_canStartMedia);
+ settings->setAcceleratedCompositingForFixedPositionEnabled(m_originalCompositingForFixedPositionEnabled);
settings->setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(m_langAttributeAwareFormControlUIEnabled);
settings->setImagesEnabled(m_imagesEnabled);
Modified: trunk/Source/WebCore/testing/InternalSettings.h (133398 => 133399)
--- trunk/Source/WebCore/testing/InternalSettings.h 2012-11-03 20:48:08 UTC (rev 133398)
+++ trunk/Source/WebCore/testing/InternalSettings.h 2012-11-03 20:52:17 UTC (rev 133399)
@@ -79,6 +79,7 @@
bool m_originalDialogElementEnabled;
#endif
bool m_canStartMedia;
+ bool m_originalCompositingForFixedPositionEnabled;
bool m_originalMockScrollbarsEnabled;
bool m_langAttributeAwareFormControlUIEnabled;
bool m_imagesEnabled;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
