Title: [133648] trunk/LayoutTests
- Revision
- 133648
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-06 11:18:36 -0800 (Tue, 06 Nov 2012)
Log Message
[CSS Regions] Fix failing tests on Mac after sub-pixel layout was enabled
https://bugs.webkit.org/show_bug.cgi?id=101364
Patch by Andrei Bucur <abu...@adobe.com> on 2012-11-06
Reviewed by Simon Fraser.
There are no changes in the code. Only the tests had to be fixed.
* fast/regions/float-pushed-width-change-expected.html: Remove the unnecessary 0.5px margin.
* fast/regions/floats-basic-in-variable-width-regions-expected.html: Because of how regions are implemented, the left offset for lines is 50px (the float width) - X.5px (margin: auto gives a different value in the two regions). This translated into 37.5px which triggered a sub-pixel layout issue. The new width values changes the X.5px into a rounded value.
* fast/regions/floats-basic-in-variable-width-regions.html: See above
* fast/regions/render-region-renderer-expected.html: Remove unnecessary 0.5px height.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (133647 => 133648)
--- trunk/LayoutTests/ChangeLog 2012-11-06 19:15:32 UTC (rev 133647)
+++ trunk/LayoutTests/ChangeLog 2012-11-06 19:18:36 UTC (rev 133648)
@@ -1,3 +1,17 @@
+2012-11-06 Andrei Bucur <abu...@adobe.com>
+
+ [CSS Regions] Fix failing tests on Mac after sub-pixel layout was enabled
+ https://bugs.webkit.org/show_bug.cgi?id=101364
+
+ Reviewed by Simon Fraser.
+
+ There are no changes in the code. Only the tests had to be fixed.
+
+ * fast/regions/float-pushed-width-change-expected.html: Remove the unnecessary 0.5px margin.
+ * fast/regions/floats-basic-in-variable-width-regions-expected.html: Because of how regions are implemented, the left offset for lines is 50px (the float width) - X.5px (margin: auto gives a different value in the two regions). This translated into 37.5px which triggered a sub-pixel layout issue. The new width values changes the X.5px into a rounded value.
+ * fast/regions/floats-basic-in-variable-width-regions.html: See above
+ * fast/regions/render-region-renderer-expected.html: Remove unnecessary 0.5px height.
+
2012-11-06 Joshua Bell <jsb...@chromium.org>
[Chromium] platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html flaky on linux debug
Modified: trunk/LayoutTests/fast/regions/float-pushed-width-change-expected.html (133647 => 133648)
--- trunk/LayoutTests/fast/regions/float-pushed-width-change-expected.html 2012-11-06 19:15:32 UTC (rev 133647)
+++ trunk/LayoutTests/fast/regions/float-pushed-width-change-expected.html 2012-11-06 19:18:36 UTC (rev 133648)
@@ -56,7 +56,7 @@
}
p.flow2 {
- margin-top: 0.5px;
+ margin-top: 0px;
}
</style>
Modified: trunk/LayoutTests/fast/regions/floats-basic-in-variable-width-regions-expected.html (133647 => 133648)
--- trunk/LayoutTests/fast/regions/floats-basic-in-variable-width-regions-expected.html 2012-11-06 19:15:32 UTC (rev 133647)
+++ trunk/LayoutTests/fast/regions/floats-basic-in-variable-width-regions-expected.html 2012-11-06 19:18:36 UTC (rev 133648)
@@ -32,7 +32,7 @@
}
#region1 {
- width: 290px;
+ width: 270px;
height: 95px;
padding-top:5px;
padding-left:5px;
Modified: trunk/LayoutTests/fast/regions/floats-basic-in-variable-width-regions.html (133647 => 133648)
--- trunk/LayoutTests/fast/regions/floats-basic-in-variable-width-regions.html 2012-11-06 19:15:32 UTC (rev 133647)
+++ trunk/LayoutTests/fast/regions/floats-basic-in-variable-width-regions.html 2012-11-06 19:18:36 UTC (rev 133648)
@@ -22,7 +22,7 @@
}
#region1 {
- width: 300px;
+ width: 280px;
height: 100px;
}
Modified: trunk/LayoutTests/fast/regions/render-region-renderer-expected.html (133647 => 133648)
--- trunk/LayoutTests/fast/regions/render-region-renderer-expected.html 2012-11-06 19:15:32 UTC (rev 133647)
+++ trunk/LayoutTests/fast/regions/render-region-renderer-expected.html 2012-11-06 19:18:36 UTC (rev 133648)
@@ -14,7 +14,7 @@
}
.size1
{
- height:0.5px;
+ height:0px;
}
.size2
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
