Title: [133740] trunk/Source/WebKit2
Revision
133740
Author
commit-qu...@webkit.org
Date
2012-11-07 05:33:40 -0800 (Wed, 07 Nov 2012)

Log Message

[EFL][WK2] Change encoding detector API names
https://bugs.webkit.org/show_bug.cgi?id=101450

Patch by Kangil Han <kangil....@samsung.com> on 2012-11-07
Reviewed by Gyuyoung Kim.

To make settings API name consistent, we need to change two APIs with respect to encoding detector.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (133739 => 133740)


--- trunk/Source/WebKit2/ChangeLog	2012-11-07 13:15:37 UTC (rev 133739)
+++ trunk/Source/WebKit2/ChangeLog	2012-11-07 13:33:40 UTC (rev 133740)
@@ -1,3 +1,19 @@
+2012-11-07  Kangil Han  <kangil....@samsung.com>
+
+        [EFL][WK2] Change encoding detector API names
+        https://bugs.webkit.org/show_bug.cgi?id=101450
+
+        Reviewed by Gyuyoung Kim.
+
+        To make settings API name consistent, we need to change two APIs with respect to encoding detector.
+
+        * UIProcess/API/efl/ewk_settings.cpp:
+        (ewk_settings_encoding_detector_enabled_set):
+        (ewk_settings_encoding_detector_enabled_get):
+        * UIProcess/API/efl/ewk_settings.h:
+        * UIProcess/API/efl/tests/test_ewk2_settings.cpp:
+        (TEST_F):
+
 2012-11-07  Grzegorz Czajkowski  <g.czajkow...@samsung.com>
 
         WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'

Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp (133739 => 133740)


--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp	2012-11-07 13:15:37 UTC (rev 133739)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp	2012-11-07 13:33:40 UTC (rev 133740)
@@ -271,7 +271,7 @@
     return listOflanguages;
 }
 
-Eina_Bool ewk_setting_encoding_detector_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
+Eina_Bool ewk_settings_encoding_detector_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
 {
     EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
 
@@ -280,7 +280,7 @@
     return true;
 }
 
-Eina_Bool ewk_setting_encoding_detector_enabled_get(const Ewk_Settings* settings)
+Eina_Bool ewk_settings_encoding_detector_enabled_get(const Ewk_Settings* settings)
 {
     EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
 

Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h (133739 => 133740)


--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h	2012-11-07 13:15:37 UTC (rev 133739)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h	2012-11-07 13:33:40 UTC (rev 133740)
@@ -309,7 +309,7 @@
  *
  * @return @c EINA_TRUE on success or @c EINA_FALSE on failure
  */
-EAPI Eina_Bool ewk_setting_encoding_detector_enabled_set(Ewk_Settings *settings, Eina_Bool enable);
+EAPI Eina_Bool ewk_settings_encoding_detector_enabled_set(Ewk_Settings *settings, Eina_Bool enable);
 
 /**
 * Returns whether the encoding detector is enabled or not.
@@ -319,7 +319,7 @@
  * @return @c EINA_TRUE if the encoding detector is enabled
  *         @c EINA_FALSE if not or on failure
  */
-EAPI Eina_Bool ewk_setting_encoding_detector_enabled_get(const Ewk_Settings *settings);
+EAPI Eina_Bool ewk_settings_encoding_detector_enabled_get(const Ewk_Settings *settings);
 
 #ifdef __cplusplus
 }

Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp (133739 => 133740)


--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp	2012-11-07 13:15:37 UTC (rev 133739)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp	2012-11-07 13:33:40 UTC (rev 133740)
@@ -158,16 +158,16 @@
     ASSERT_FALSE(ewk_settings_dns_prefetching_enabled_get(settings));
 }
 
-TEST_F(EWK2UnitTestBase, ewk_setting_encoding_detector_enabled)
+TEST_F(EWK2UnitTestBase, ewk_settings_encoding_detector_enabled)
 {
     Ewk_Settings* settings = ewk_view_settings_get(webView());
 
     // The encoding detector is disabled by default.
-    ASSERT_FALSE(ewk_setting_encoding_detector_enabled_get(settings));
+    ASSERT_FALSE(ewk_settings_encoding_detector_enabled_get(settings));
 
-    ASSERT_TRUE(ewk_setting_encoding_detector_enabled_set(settings, true));
-    ASSERT_TRUE(ewk_setting_encoding_detector_enabled_get(settings));
+    ASSERT_TRUE(ewk_settings_encoding_detector_enabled_set(settings, true));
+    ASSERT_TRUE(ewk_settings_encoding_detector_enabled_get(settings));
 
-    ASSERT_TRUE(ewk_setting_encoding_detector_enabled_set(settings, false));
-    ASSERT_FALSE(ewk_setting_encoding_detector_enabled_get(settings));
+    ASSERT_TRUE(ewk_settings_encoding_detector_enabled_set(settings, false));
+    ASSERT_FALSE(ewk_settings_encoding_detector_enabled_get(settings));
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to