Title: [133782] trunk/LayoutTests
Revision
133782
Author
rak...@webkit.org
Date
2012-11-07 10:53:55 -0800 (Wed, 07 Nov 2012)

Log Message

Enable text dump in fast/forms/file/get-file-upload.html earlier.
https://bugs.webkit.org/show_bug.cgi?id=101468

Reviewed by Kentaro Hara.

Do not call testRunner.dumpAsText() only when processing the form
submission, since that will not be triggered if a port does not
support, say, beginDragWithFiles(), and a useless pixel result
will be generated in that case.

Instead, call dumpAsText() as early as possible.

* fast/forms/file/get-file-upload.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (133781 => 133782)


--- trunk/LayoutTests/ChangeLog	2012-11-07 18:49:08 UTC (rev 133781)
+++ trunk/LayoutTests/ChangeLog	2012-11-07 18:53:55 UTC (rev 133782)
@@ -1,3 +1,19 @@
+2012-11-07  Raphael Kubo da Costa  <raphael.kubo.da.co...@intel.com>
+
+        Enable text dump in fast/forms/file/get-file-upload.html earlier.
+        https://bugs.webkit.org/show_bug.cgi?id=101468
+
+        Reviewed by Kentaro Hara.
+
+        Do not call testRunner.dumpAsText() only when processing the form
+        submission, since that will not be triggered if a port does not
+        support, say, beginDragWithFiles(), and a useless pixel result
+        will be generated in that case.
+
+        Instead, call dumpAsText() as early as possible.
+
+        * fast/forms/file/get-file-upload.html:
+
 2012-11-07  Joshua Bell  <jsb...@chromium.org>
 
         IndexedDB: Assertion failure with open() within upgradeneeded

Modified: trunk/LayoutTests/fast/forms/file/get-file-upload.html (133781 => 133782)


--- trunk/LayoutTests/fast/forms/file/get-file-upload.html	2012-11-07 18:49:08 UTC (rev 133781)
+++ trunk/LayoutTests/fast/forms/file/get-file-upload.html	2012-11-07 18:53:55 UTC (rev 133782)
@@ -12,7 +12,7 @@
 {
     document.getElementById('console').appendChild(document.createTextNode(message + "\n"));
 }
-            
+
 function startOrVerify()
 {
     var query = window.location.search;
@@ -22,7 +22,6 @@
             log('PASS: ' + query);
         else
             log('FAIL: ' + query);
-        testRunner.dumpAsText();
         testRunner.notifyDone();
     } else {
         // Start the test
@@ -34,6 +33,7 @@
 }
 
 if (window.eventSender) {
+    testRunner.dumpAsText();
     testRunner.waitUntilDone();
     window._onload_ = startOrVerify;
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to