Title: [134202] trunk/Source/WebCore
- Revision
- 134202
- Author
- [email protected]
- Date
- 2012-11-12 03:23:11 -0800 (Mon, 12 Nov 2012)
Log Message
'for (x in y)' requires 'var' declaration in ConsoleMessage.js
https://bugs.webkit.org/show_bug.cgi?id=101908
Reviewed by Pavel Feldman.
r134166 should have included a 'var' declaration in its 'for (x in y)'
loop. This patch adds the missing 'var' in order to prevent leakage into
the global context.
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134201 => 134202)
--- trunk/Source/WebCore/ChangeLog 2012-11-12 11:20:55 UTC (rev 134201)
+++ trunk/Source/WebCore/ChangeLog 2012-11-12 11:23:11 UTC (rev 134202)
@@ -1,3 +1,18 @@
+2012-11-12 Mike West <[email protected]>
+
+ 'for (x in y)' requires 'var' declaration in ConsoleMessage.js
+ https://bugs.webkit.org/show_bug.cgi?id=101908
+
+ Reviewed by Pavel Feldman.
+
+ r134166 should have included a 'var' declaration in its 'for (x in y)'
+ loop. This patch adds the missing 'var' in order to prevent leakage into
+ the global context.
+
+ * inspector/front-end/ConsoleMessage.js:
+ (WebInspector.ConsoleMessageImpl.prototype.append):
+ (WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
+
2012-11-12 Zeno Albisser <[email protected]>
[Qt] MiniBrowser should not strongly depend on QtTestSupport.
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js (134201 => 134202)
--- trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js 2012-11-12 11:20:55 UTC (rev 134201)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js 2012-11-12 11:23:11 UTC (rev 134202)
@@ -522,7 +522,7 @@
var toAppend = WebInspector.linkifyStringAsFragment(b.toString());
if (currentStyle) {
var wrapper = document.createElement('span');
- for (key in currentStyle)
+ for (var key in currentStyle)
wrapper.style[key] = currentStyle[key];
wrapper.appendChild(toAppend);
toAppend = wrapper;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
