Title: [134445] trunk/Tools
- Revision
- 134445
- Author
- [email protected]
- Date
- 2012-11-13 10:59:54 -0800 (Tue, 13 Nov 2012)
Log Message
Fix webkitpy issues arising from a partially-installed pylint.
Unreviewed, build fix.
This patch ensures that we will re-install the pylint and logilab
packages if any of them are missing, not just the pylint package.
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._install_pylint):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (134444 => 134445)
--- trunk/Tools/ChangeLog 2012-11-13 18:58:29 UTC (rev 134444)
+++ trunk/Tools/ChangeLog 2012-11-13 18:59:54 UTC (rev 134445)
@@ -1,3 +1,14 @@
+2012-11-13 Dirk Pranke <[email protected]>
+
+ Fix webkitpy issues arising from a partially-installed pylint.
+ Unreviewed, build fix.
+
+ This patch ensures that we will re-install the pylint and logilab
+ packages if any of them are missing, not just the pylint package.
+
+ * Scripts/webkitpy/thirdparty/__init__.py:
+ (AutoinstallImportHook._install_pylint):
+
2012-11-13 No'am Rosenthal <[email protected]>
Unreviewed, adding my new email address to committers.py and watchlist.
Modified: trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py (134444 => 134445)
--- trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py 2012-11-13 18:58:29 UTC (rev 134444)
+++ trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py 2012-11-13 18:59:54 UTC (rev 134445)
@@ -105,7 +105,9 @@
def _install_pylint(self):
self._ensure_autoinstalled_dir_is_in_sys_path()
did_install_something = False
- if not self._fs.exists(self._fs.join(_AUTOINSTALLED_DIR, "pylint")):
+ if (not self._fs.exists(self._fs.join(_AUTOINSTALLED_DIR, "pylint")) or
+ not self._fs.exists(self._fs.join(_AUTOINSTALLED_DIR, "logilab/astng")) or
+ not self._fs.exists(self._fs.join(_AUTOINSTALLED_DIR, "logilab/common"))):
installer = AutoInstaller(target_dir=_AUTOINSTALLED_DIR)
did_install_something = installer.install("http://pypi.python.org/packages/source/l/logilab-common/logilab-common-0.58.1.tar.gz#md5=77298ab2d8bb8b4af9219791e7cee8ce", url_subpath="logilab-common-0.58.1", target_name="logilab/common")
did_install_something |= installer.install("http://pypi.python.org/packages/source/l/logilab-astng/logilab-astng-0.24.1.tar.gz#md5=ddaf66e4d85714d9c47a46d4bed406de", url_subpath="logilab-astng-0.24.1", target_name="logilab/astng")
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
