Title: [134483] trunk/Source/WebCore
- Revision
- 134483
- Author
- [email protected]
- Date
- 2012-11-13 14:19:57 -0800 (Tue, 13 Nov 2012)
Log Message
CSSParser::setStyleSheet() should be inline
https://bugs.webkit.org/show_bug.cgi?id=101829
Reviewed by Andreas Kling.
* css/CSSParser.cpp:
* css/CSSParser.h:
(WebCore::CSSParser::setStyleSheet):
CSSParser::setStyleSheet() just assign a pointer, it does not even
change a ref-count. The function should probably be in the header.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134482 => 134483)
--- trunk/Source/WebCore/ChangeLog 2012-11-13 22:14:05 UTC (rev 134482)
+++ trunk/Source/WebCore/ChangeLog 2012-11-13 22:19:57 UTC (rev 134483)
@@ -1,3 +1,16 @@
+2012-11-13 Benjamin Poulain <[email protected]>
+
+ CSSParser::setStyleSheet() should be inline
+ https://bugs.webkit.org/show_bug.cgi?id=101829
+
+ Reviewed by Andreas Kling.
+
+ * css/CSSParser.cpp:
+ * css/CSSParser.h:
+ (WebCore::CSSParser::setStyleSheet):
+ CSSParser::setStyleSheet() just assign a pointer, it does not even
+ change a ref-count. The function should probably be in the header.
+
2012-11-13 Andrei Bucur <[email protected]>
[CSS Regions] Add Region info for RootLineBoxes and pack the pagination data
Modified: trunk/Source/WebCore/css/CSSParser.cpp (134482 => 134483)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-11-13 22:14:05 UTC (rev 134482)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-11-13 22:19:57 UTC (rev 134483)
@@ -1452,11 +1452,6 @@
m_hasFontFaceOnlyValues = false;
}
-void CSSParser::setStyleSheet(StyleSheetContents* styleSheet)
-{
- m_styleSheet = styleSheet;
-}
-
KURL CSSParser::completeURL(const CSSParserContext& context, const String& url)
{
if (url.isNull())
Modified: trunk/Source/WebCore/css/CSSParser.h (134482 => 134483)
--- trunk/Source/WebCore/css/CSSParser.h 2012-11-13 22:14:05 UTC (rev 134482)
+++ trunk/Source/WebCore/css/CSSParser.h 2012-11-13 22:19:57 UTC (rev 134483)
@@ -451,7 +451,7 @@
template <typename CharacterType>
inline void setRuleHeaderEnd(const CharacterType*);
- void setStyleSheet(StyleSheetContents*);
+ void setStyleSheet(StyleSheetContents* styleSheet) { m_styleSheet = styleSheet; }
inline bool inStrictMode() const { return m_context.mode == CSSStrictMode || m_context.mode == SVGAttributeMode; }
inline bool inQuirksMode() const { return m_context.mode == CSSQuirksMode; }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
