Diff
Modified: trunk/LayoutTests/ChangeLog (134654 => 134655)
--- trunk/LayoutTests/ChangeLog 2012-11-14 20:52:56 UTC (rev 134654)
+++ trunk/LayoutTests/ChangeLog 2012-11-14 21:05:40 UTC (rev 134655)
@@ -1,3 +1,16 @@
+2012-11-14 Erik Arvidsson <[email protected]>
+
+ Update DOMException name: WrongDocumentError
+ https://bugs.webkit.org/show_bug.cgi?id=102096
+
+ Reviewed by Ojan Vafai.
+
+ Updated tests and expectations.
+
+ * fast/dom/Range/compareBoundaryPoints-1-expected.txt:
+ * fast/dom/Range/compareBoundaryPoints-1.html:
+ * fast/dom/move-nodes-across-documents.html:
+
2012-11-14 Nate Chapin <[email protected]>
Move empty loading to DocumentLoader, simplify FrameLoader::init()
Modified: trunk/LayoutTests/fast/dom/Range/compareBoundaryPoints-1-expected.txt (134654 => 134655)
--- trunk/LayoutTests/fast/dom/Range/compareBoundaryPoints-1-expected.txt 2012-11-14 20:52:56 UTC (rev 134654)
+++ trunk/LayoutTests/fast/dom/Range/compareBoundaryPoints-1-expected.txt 2012-11-14 21:05:40 UTC (rev 134655)
@@ -1,4 +1,4 @@
-This tests to see that Range::compareBoundaryPoints throws a WRONG_DOCUMENT_ERROR exception if the two ranges are in different documents, or if one is detached.
+This tests to see that Range::compareBoundaryPoints throws a WrongDocumentError exception if the two ranges are in different documents, or if one is detached.
food
Modified: trunk/LayoutTests/fast/dom/Range/compareBoundaryPoints-1.html (134654 => 134655)
--- trunk/LayoutTests/fast/dom/Range/compareBoundaryPoints-1.html 2012-11-14 20:52:56 UTC (rev 134654)
+++ trunk/LayoutTests/fast/dom/Range/compareBoundaryPoints-1.html 2012-11-14 21:05:40 UTC (rev 134655)
@@ -1,4 +1,4 @@
-<p>This tests to see that Range::compareBoundaryPoints throws a WRONG_DOCUMENT_ERROR exception if the two ranges are in different documents, or if one is detached.</p>
+<p>This tests to see that Range::compareBoundaryPoints throws a WrongDocumentError exception if the two ranges are in different documents, or if one is detached.</p>
<div id="div" contenteditable="true">dog<a href=""
<ul id="console"></ul>
@@ -32,7 +32,7 @@
var compare = r1.compareBoundaryPoints(Range.START_TO_START, r2);
log("Error. compareBoundaryPoints should have thrown an exception.");
} catch (e) {
- var expected = "Error: WRONG_DOCUMENT_ERR: DOM Exception 4";
+ var expected = "Error: WrongDocumentError: DOM Exception 4";
if (e != expected)
log("Error. Exception thrown should have been: " + expected);
}
Modified: trunk/LayoutTests/fast/dom/move-nodes-across-documents.html (134654 => 134655)
--- trunk/LayoutTests/fast/dom/move-nodes-across-documents.html 2012-11-14 20:52:56 UTC (rev 134654)
+++ trunk/LayoutTests/fast/dom/move-nodes-across-documents.html 2012-11-14 21:05:40 UTC (rev 134655)
@@ -168,13 +168,13 @@
});
runTest(function() {
iframeDoc.implementation.createDocument('', 'html', document.doctype);
- }, 'WRONG_DOCUMENT_ERR');
+ }, 'WrongDocumentError');
runTest(function() {
rangeInIframe().compareBoundaryPoints(Range.END_TO_END, rangeInCurrentDocument());
- }, 'WRONG_DOCUMENT_ERR');
+ }, 'WrongDocumentError');
runTest(function() {
rangeInIframe().comparePoint(elementInCurrentDocument('comparePoint'), 0);
- }, 'WRONG_DOCUMENT_ERR');
+ }, 'WrongDocumentError');
runTest(function() {
iframeDoc.appendChild(document.doctype);
Modified: trunk/Source/WebCore/ChangeLog (134654 => 134655)
--- trunk/Source/WebCore/ChangeLog 2012-11-14 20:52:56 UTC (rev 134654)
+++ trunk/Source/WebCore/ChangeLog 2012-11-14 21:05:40 UTC (rev 134655)
@@ -1,3 +1,16 @@
+2012-11-14 Erik Arvidsson <[email protected]>
+
+ Update DOMException name: WrongDocumentError
+ https://bugs.webkit.org/show_bug.cgi?id=102096
+
+ Reviewed by Ojan Vafai.
+
+ Patch 4 of 25 to update DOMException name to match the spec and Firefox.
+
+ Updated existing tests.
+
+ * dom/DOMCoreException.cpp:
+
2012-11-14 Nate Chapin <[email protected]>
Move empty loading to DocumentLoader, simplify FrameLoader::init()
Modified: trunk/Source/WebCore/dom/DOMCoreException.cpp (134654 => 134655)
--- trunk/Source/WebCore/dom/DOMCoreException.cpp 2012-11-14 20:52:56 UTC (rev 134654)
+++ trunk/Source/WebCore/dom/DOMCoreException.cpp 2012-11-14 21:05:40 UTC (rev 134655)
@@ -38,7 +38,7 @@
{ "IndexSizeError", "Index or size was negative, or greater than the allowed value." },
{ "DOMSTRING_SIZE_ERR", "The specified range of text did not fit into a DOMString." },
{ "HierarchyRequestError", "A Node was inserted somewhere it doesn't belong." },
- { "WRONG_DOCUMENT_ERR", "A Node was used in a different document than the one that created it (that doesn't support it)." },
+ { "WrongDocumentError", "A Node was used in a different document than the one that created it (that doesn't support it)." },
{ "InvalidCharacterError", "An invalid or illegal character was specified, such as in an XML name." },
{ "NoDataAllowedError", "Data was specified for a Node which does not support data." },
{ "NO_MODIFICATION_ALLOWED_ERR", "An attempt was made to modify an object where modifications are not allowed." },