Title: [134659] trunk
- Revision
- 134659
- Author
- [email protected]
- Date
- 2012-11-14 13:27:51 -0800 (Wed, 14 Nov 2012)
Log Message
Update DOMException name: InUseAttributeError
https://bugs.webkit.org/show_bug.cgi?id=102141
Reviewed by Ojan Vafai.
Patch 10 of 25 to update DOMException name to match the spec and Firefox.
The name for this is not in the spec but the case was selected to match
Firefox. http://mxr.mozilla.org/mozilla-central/source/dom/base/domerr.msg#18
INUSE_ATTRIBUTE_ERR is historical and not used in any spec or any of our tests.
* dom/DOMCoreException.cpp:
* dom/ExceptionCode.h:
Modified Paths
Diff
Modified: trunk/LayoutTests/fast/dom/move-nodes-across-documents.html (134658 => 134659)
--- trunk/LayoutTests/fast/dom/move-nodes-across-documents.html 2012-11-14 21:27:22 UTC (rev 134658)
+++ trunk/LayoutTests/fast/dom/move-nodes-across-documents.html 2012-11-14 21:27:51 UTC (rev 134659)
@@ -156,7 +156,7 @@
var attribute = document.createAttribute('asdf');
document.body.attributes.setNamedItem(attribute);
iframeDoc.body.attributes.setNamedItem(attribute);
- }, 'INUSE_ATTRIBUTE_ERR');
+ }, 'InUseAttributeError');
runTest(function() {
var doctype = document.implementation.createDocumentType(
Modified: trunk/Source/WebCore/ChangeLog (134658 => 134659)
--- trunk/Source/WebCore/ChangeLog 2012-11-14 21:27:22 UTC (rev 134658)
+++ trunk/Source/WebCore/ChangeLog 2012-11-14 21:27:51 UTC (rev 134659)
@@ -1,3 +1,20 @@
+2012-11-14 Erik Arvidsson <[email protected]>
+
+ Update DOMException name: InUseAttributeError
+ https://bugs.webkit.org/show_bug.cgi?id=102141
+
+ Reviewed by Ojan Vafai.
+
+ Patch 10 of 25 to update DOMException name to match the spec and Firefox.
+
+ The name for this is not in the spec but the case was selected to match
+ Firefox. http://mxr.mozilla.org/mozilla-central/source/dom/base/domerr.msg#18
+
+ INUSE_ATTRIBUTE_ERR is historical and not used in any spec or any of our tests.
+
+ * dom/DOMCoreException.cpp:
+ * dom/ExceptionCode.h:
+
2012-11-14 Lynn Neir <[email protected]>
[WinCairo] Incorrect line-height for styled menulist (select tag)
Modified: trunk/Source/WebCore/dom/DOMCoreException.cpp (134658 => 134659)
--- trunk/Source/WebCore/dom/DOMCoreException.cpp 2012-11-14 21:27:22 UTC (rev 134658)
+++ trunk/Source/WebCore/dom/DOMCoreException.cpp 2012-11-14 21:27:51 UTC (rev 134659)
@@ -44,7 +44,7 @@
{ "NO_MODIFICATION_ALLOWED_ERR", "An attempt was made to modify an object where modifications are not allowed." },
{ "NotFoundError", "An attempt was made to reference a Node in a context where it does not exist." },
{ "NOT_SUPPORTED_ERR", "The implementation did not support the requested type of object or operation." },
- { "INUSE_ATTRIBUTE_ERR", "An attempt was made to add an attribute that is already in use elsewhere." },
+ { "InUseAttributeError", "An attempt was made to add an attribute that is already in use elsewhere." },
{ "InvalidStateError", "An attempt was made to use an object that is not, or is no longer, usable." },
{ "SYNTAX_ERR", "An invalid or illegal string was specified." },
{ "INVALID_MODIFICATION_ERR", "An attempt was made to modify the type of the underlying object." },
Modified: trunk/Source/WebCore/dom/ExceptionCode.h (134658 => 134659)
--- trunk/Source/WebCore/dom/ExceptionCode.h 2012-11-14 21:27:22 UTC (rev 134658)
+++ trunk/Source/WebCore/dom/ExceptionCode.h 2012-11-14 21:27:51 UTC (rev 134659)
@@ -43,7 +43,7 @@
NO_MODIFICATION_ALLOWED_ERR = 7,
NOT_FOUND_ERR = 8,
NOT_SUPPORTED_ERR = 9,
- INUSE_ATTRIBUTE_ERR = 10,
+ INUSE_ATTRIBUTE_ERR = 10, // Historical
// Introduced in DOM Level 2:
INVALID_STATE_ERR = 11,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
