Title: [134685] trunk/Source/WebCore
- Revision
- 134685
- Author
- jsb...@chromium.org
- Date
- 2012-11-14 15:52:06 -0800 (Wed, 14 Nov 2012)
Log Message
IndexedDB: Indexing tests are flaky-crashing
https://bugs.webkit.org/show_bug.cgi?id=102283
Reviewed by Tony Chang.
Don't commit the transaction if there are outstanding pre-emptive events
from indexing operations.
Speculative fix for the flakiness.
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (134684 => 134685)
--- trunk/Source/WebCore/ChangeLog 2012-11-14 23:43:25 UTC (rev 134684)
+++ trunk/Source/WebCore/ChangeLog 2012-11-14 23:52:06 UTC (rev 134685)
@@ -1,3 +1,18 @@
+2012-11-14 Joshua Bell <jsb...@chromium.org>
+
+ IndexedDB: Indexing tests are flaky-crashing
+ https://bugs.webkit.org/show_bug.cgi?id=102283
+
+ Reviewed by Tony Chang.
+
+ Don't commit the transaction if there are outstanding pre-emptive events
+ from indexing operations.
+
+ Speculative fix for the flakiness.
+
+ * Modules/indexeddb/IDBTransactionBackendImpl.cpp:
+ (WebCore::IDBTransactionBackendImpl::taskEventTimerFired):
+
2012-11-14 Tony Chang <t...@chromium.org>
Crash in flexbox when removing absolutely positioned children
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp (134684 => 134685)
--- trunk/Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp 2012-11-14 23:43:25 UTC (rev 134684)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp 2012-11-14 23:52:06 UTC (rev 134685)
@@ -262,7 +262,7 @@
IDB_TRACE("IDBTransactionBackendImpl::taskEventTimerFired");
ASSERT(m_state == Running);
- if (!m_pendingEvents && isTaskQueueEmpty()) {
+ if (!m_pendingEvents && !m_pendingPreemptiveEvents && isTaskQueueEmpty()) {
// The last task event has completed and the task
// queue is empty. Commit the transaction.
commit();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
