Diff
Modified: trunk/Source/WebCore/ChangeLog (134918 => 134919)
--- trunk/Source/WebCore/ChangeLog 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebCore/ChangeLog 2012-11-16 10:31:10 UTC (rev 134919)
@@ -1,3 +1,28 @@
+2012-11-16 Helder Correia <helder.corr...@nokia.com>
+
+ [CoordGfx] Follow coding style on explicit constructors
+ https://bugs.webkit.org/show_bug.cgi?id=102451
+
+ Reviewed by Noam Rosenthal.
+
+ Use the explicit keyword on single argument constructors.
+
+ No new tests needed.
+
+ * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
+ (GraphicsLayerTextureMapper):
+ * platform/graphics/texmap/TextureMapper.h:
+ (TextureMapper):
+ * platform/graphics/texmap/TextureMapperBackingStore.h:
+ (WebCore::TextureMapperTile::TextureMapperTile):
+ * platform/graphics/texmap/TextureMapperGL.cpp:
+ (WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
+ (WebCore::TextureMapperGLData::TextureMapperGLData):
+ * platform/graphics/texmap/TextureMapperGL.h:
+ (BitmapTextureGL):
+ * platform/graphics/texmap/TextureMapperShaderManager.h:
+ (TextureMapperShaderManager):
+
2012-11-16 Kihong Kwon <kihong.k...@samsung.com>
Add DeviceController base-class to remove duplication of DeviceXXXControler
Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h (134918 => 134919)
--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h 2012-11-16 10:31:10 UTC (rev 134919)
@@ -36,7 +36,7 @@
friend class TextureMapperLayer;
public:
- GraphicsLayerTextureMapper(GraphicsLayerClient*);
+ explicit GraphicsLayerTextureMapper(GraphicsLayerClient*);
virtual ~GraphicsLayerTextureMapper();
// reimps from GraphicsLayer.h
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h (134918 => 134919)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h 2012-11-16 10:31:10 UTC (rev 134919)
@@ -155,7 +155,7 @@
virtual PassRefPtr<BitmapTexture> acquireTextureFromPool(const IntSize&);
protected:
- TextureMapper(AccelerationMode);
+ explicit TextureMapper(AccelerationMode);
private:
#if USE(TEXTURE_MAPPER_GL)
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h (134918 => 134919)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h 2012-11-16 10:31:10 UTC (rev 134919)
@@ -81,7 +81,7 @@
virtual void paint(TextureMapper*, const TransformationMatrix&, float, BitmapTexture*, const unsigned exposedEdges);
virtual ~TextureMapperTile() { }
- TextureMapperTile(const FloatRect& rect)
+ explicit TextureMapperTile(const FloatRect& rect)
: m_rect(rect)
{
}
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (134918 => 134919)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-11-16 10:31:10 UTC (rev 134919)
@@ -89,7 +89,7 @@
TextureMapperShaderManager textureMapperShaderManager;
- SharedGLData(GraphicsContext3D* context)
+ explicit SharedGLData(GraphicsContext3D* context)
: textureMapperShaderManager(context)
{
glContextDataMap().add(context->platformGraphicsContext3D(), this);
@@ -116,7 +116,7 @@
void initializeStencil();
- TextureMapperGLData(GraphicsContext3D* context)
+ explicit TextureMapperGLData(GraphicsContext3D* context)
: context(context)
, PaintFlags(0)
, previousProgram(0)
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.h (134918 => 134919)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.h 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.h 2012-11-16 10:31:10 UTC (rev 134919)
@@ -165,7 +165,7 @@
TextureMapperGL::ClipStack m_clipStack;
RefPtr<GraphicsContext3D> m_context3D;
- BitmapTextureGL(TextureMapperGL*);
+ explicit BitmapTextureGL(TextureMapperGL*);
BitmapTextureGL();
void clearIfNeeded();
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h (134918 => 134919)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h 2012-11-16 10:31:10 UTC (rev 134919)
@@ -105,7 +105,7 @@
};
TextureMapperShaderManager() { }
- TextureMapperShaderManager(GraphicsContext3D*);
+ explicit TextureMapperShaderManager(GraphicsContext3D*);
virtual ~TextureMapperShaderManager();
PassRefPtr<TextureMapperShaderProgram> getShaderProgram(ShaderKey);
Modified: trunk/Source/WebKit2/ChangeLog (134918 => 134919)
--- trunk/Source/WebKit2/ChangeLog 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-16 10:31:10 UTC (rev 134919)
@@ -1,3 +1,19 @@
+2012-11-16 Helder Correia <helder.corr...@nokia.com>
+
+ [CoordGfx] Follow coding style on explicit constructors
+ https://bugs.webkit.org/show_bug.cgi?id=102451
+
+ Reviewed by Noam Rosenthal.
+
+ Use the explicit keyword on single argument constructors.
+
+ No new tests needed.
+
+ * UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:
+ (WebKit::CoordinatedBackingStoreTile::CoordinatedBackingStoreTile):
+ * WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:
+ (CoordinatedTileBackend):
+
2012-11-16 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r134908.
Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h (134918 => 134919)
--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h 2012-11-16 10:31:10 UTC (rev 134919)
@@ -33,7 +33,7 @@
class CoordinatedBackingStoreTile : public WebCore::TextureMapperTile {
public:
- CoordinatedBackingStoreTile(float scale = 1)
+ explicit CoordinatedBackingStoreTile(float scale = 1)
: TextureMapperTile(WebCore::FloatRect())
, m_scale(scale)
, m_repaintCount(0)
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h (134918 => 134919)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h 2012-11-16 10:19:41 UTC (rev 134918)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h 2012-11-16 10:31:10 UTC (rev 134919)
@@ -88,7 +88,7 @@
void paintCheckerPattern(WebCore::GraphicsContext*, const WebCore::FloatRect&);
private:
- CoordinatedTileBackend(CoordinatedTileClient*);
+ explicit CoordinatedTileBackend(CoordinatedTileClient*);
CoordinatedTileClient* m_client;
};
