Title: [134957] trunk/Source/WebKit/blackberry
- Revision
- 134957
- Author
- mifen...@rim.com
- Date
- 2012-11-16 08:57:45 -0800 (Fri, 16 Nov 2012)
Log Message
[BlackBerry] Use proper keycode value for space instead of hardcoded value.
https://bugs.webkit.org/show_bug.cgi?id=102518
Reviewed by Rob Buis.
Remove hard coded value for space.
Reviewed Internally by Gen Mak.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setText):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (134956 => 134957)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-16 16:56:47 UTC (rev 134956)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-16 16:57:45 UTC (rev 134957)
@@ -1,3 +1,17 @@
+2012-11-16 Mike Fenton <mifen...@rim.com>
+
+ [BlackBerry] Use proper keycode value for space instead of hardcoded value.
+ https://bugs.webkit.org/show_bug.cgi?id=102518
+
+ Reviewed by Rob Buis.
+
+ Remove hard coded value for space.
+
+ Reviewed Internally by Gen Mak.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::setText):
+
2012-11-15 Andrew Lo <a...@rim.com>
[BlackBerry] Animate changes to viewport due to input focus changes.
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (134956 => 134957)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-16 16:56:47 UTC (rev 134956)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-16 16:57:45 UTC (rev 134957)
@@ -2205,7 +2205,7 @@
// Remove it and apply it as a keypress later.
// Upstream Webkit bug created https://bugs.webkit.org/show_bug.cgi?id=70823
bool requiresSpaceKeyPress = false;
- if (textLength > 0 && textToInsert[textLength - 1] == 32 /* space */) {
+ if (textLength > 0 && textToInsert[textLength - 1] == KEYCODE_SPACE) {
requiresSpaceKeyPress = true;
textLength--;
textToInsert.remove(textLength, 1);
@@ -2227,7 +2227,7 @@
}
if (requiresSpaceKeyPress)
- handleKeyboardInput(Platform::KeyboardEvent(32 /* space */, Platform::KeyboardEvent::KeyDown, 0), true /* changeIsPartOfComposition */);
+ handleKeyboardInput(Platform::KeyboardEvent(KEYCODE_SPACE, Platform::KeyboardEvent::KeyDown, 0), true /* changeIsPartOfComposition */);
InputLog(LogLevelInfo, "InputHandler::setText Request being processed. Text after processing '%s'", elementText().latin1().data());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
