Title: [135342] trunk/Source/WebKit/chromium
Revision
135342
Author
commit-qu...@webkit.org
Date
2012-11-20 19:13:18 -0800 (Tue, 20 Nov 2012)

Log Message

[Chromium] Need spellcheck suggestions even if continuous check is off.
https://bugs.webkit.org/show_bug.cgi?id=102535

Patch by Rachel Blum <gr...@chromium.org> on 2012-11-20
Reviewed by Hajime Morita.

Make sure the context menu always has suggestions for misspelled words.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

Modified Paths

Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (135341 => 135342)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-11-21 02:34:46 UTC (rev 135341)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-11-21 03:13:18 UTC (rev 135342)
@@ -1,3 +1,15 @@
+2012-11-20  Rachel Blum  <gr...@chromium.org>
+
+        [Chromium] Need spellcheck suggestions even if continuous check is off.
+        https://bugs.webkit.org/show_bug.cgi?id=102535
+
+        Reviewed by Hajime Morita.
+
+        Make sure the context menu always has suggestions for misspelled words.
+
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+
 2012-11-20  Robert Kroeger  <rjkro...@chromium.org>
 
         [chromium] Use embedder-supported gesture curves

Modified: trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp (135341 => 135342)


--- trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp	2012-11-21 02:34:46 UTC (rev 135341)
+++ trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp	2012-11-21 03:13:18 UTC (rev 135342)
@@ -298,8 +298,9 @@
                         selectedFrame->selection()->setSelection(selection, WordGranularity);
                 }
             }
-        } else if (m_webView->focusedWebCoreFrame()->editor()->isContinuousSpellCheckingEnabled()) {
-            data.isSpellCheckingEnabled = true;
+        } else {
+            data.isSpellCheckingEnabled = 
+                m_webView->focusedWebCoreFrame()->editor()->isContinuousSpellCheckingEnabled();
             // Spellchecking might be enabled for the field, but could be disabled on the node.
             if (m_webView->focusedWebCoreFrame()->editor()->isSpellCheckingEnabledInFocusedNode()) {
                 data.misspelledWord = selectMisspelledWord(defaultMenu, selectedFrame);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to