Title: [135779] trunk/Source/WebCore
- Revision
- 135779
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-26 15:27:57 -0800 (Mon, 26 Nov 2012)
Log Message
Removing unnecessary friend classes in RenderObject: LayoutRepainter, RenderSVGContainer
https://bugs.webkit.org/show_bug.cgi?id=103164
Patch by Adenilson Cavalcanti <cavalcan...@gmail.com> on 2012-11-26
Reviewed by Simon Fraser.
Removing some of classes marked as friend of RenderObject. This patch solves this issue
for 2 classes: RenderSVGContainer (that is derived from RenderObject) and LayoutRepainter
(that accesses one const member function in RenderObject that is now made public).
No new tests, no changes in functionality.
* rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::outlineBoundsForRepaint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (135778 => 135779)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 23:18:55 UTC (rev 135778)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 23:27:57 UTC (rev 135779)
@@ -1,3 +1,20 @@
+2012-11-26 Adenilson Cavalcanti <cavalcan...@gmail.com>
+
+ Removing unnecessary friend classes in RenderObject: LayoutRepainter, RenderSVGContainer
+ https://bugs.webkit.org/show_bug.cgi?id=103164
+
+ Reviewed by Simon Fraser.
+
+ Removing some of classes marked as friend of RenderObject. This patch solves this issue
+ for 2 classes: RenderSVGContainer (that is derived from RenderObject) and LayoutRepainter
+ (that accesses one const member function in RenderObject that is now made public).
+
+ No new tests, no changes in functionality.
+
+ * rendering/RenderObject.h:
+ (RenderObject):
+ (WebCore::RenderObject::outlineBoundsForRepaint):
+
2012-11-26 Jon Lee <jon...@apple.com>
Pass clicks through to the restarted plugin
Modified: trunk/Source/WebCore/rendering/RenderObject.h (135778 => 135779)
--- trunk/Source/WebCore/rendering/RenderObject.h 2012-11-26 23:18:55 UTC (rev 135778)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2012-11-26 23:27:57 UTC (rev 135779)
@@ -155,11 +155,9 @@
// Base class for all rendering tree objects.
class RenderObject : public CachedImageClient {
- friend class LayoutRepainter;
friend class RenderBlock;
friend class RenderLayer;
friend class RenderObjectChildList;
- friend class RenderSVGContainer;
public:
// Anonymous objects should pass the document as their node, and they will then automatically be
// marked as anonymous in the constructor.
@@ -811,6 +809,7 @@
IntRect pixelSnappedAbsoluteClippedOverflowRect() const;
virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const;
virtual LayoutRect rectWithOutlineForRepaint(const RenderLayerModelObject* repaintContainer, LayoutUnit outlineWidth) const;
+ virtual LayoutRect outlineBoundsForRepaint(const RenderLayerModelObject* /*repaintContainer*/, const RenderGeometryMap* = 0) const { return LayoutRect(); }
// Given a rect in the object's coordinate space, compute a rect suitable for repainting
// that rect in view coordinates.
@@ -980,8 +979,6 @@
virtual void willBeDestroyed();
void arenaDelete(RenderArena*, void* objectBase);
- virtual LayoutRect outlineBoundsForRepaint(const RenderLayerModelObject* /*repaintContainer*/, const RenderGeometryMap* = 0) const { return LayoutRect(); }
-
virtual bool canBeReplacedWithInlineRunIn() const;
virtual void insertedIntoTree();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
