Title: [135890] trunk
- Revision
- 135890
- Author
- roger_f...@apple.com
- Date
- 2012-11-27 11:34:40 -0800 (Tue, 27 Nov 2012)
Log Message
Windows specific implementation of usesTileCacheLayer needed after r133056.
https://bugs.webkit.org/show_bug.cgi?id=103321
Reviewed by Simon Fraser.
After r133056 it no longer suffices to use the existing usesTileCacheLayer method on Windows.
The change resulted in 3 crashing tests:
compositing/rotated-tiled-clamped
compositing/rotated-tiled-preserve3d-clamped
fast/events/tabindex-focus-blur-all
* platform/win/TestExpectations:
Remove the tests below from the Windows skip list.
* platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
* platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
Add Windows specific results for tests added in r133056.
* platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::usesTileCacheLayer):
(PlatformCALayer):
Adding in platform specific method for Windows that returns false for this method.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (135889 => 135890)
--- trunk/LayoutTests/ChangeLog 2012-11-27 19:31:39 UTC (rev 135889)
+++ trunk/LayoutTests/ChangeLog 2012-11-27 19:34:40 UTC (rev 135890)
@@ -1,3 +1,23 @@
+2012-11-27 Roger Fong <roger_f...@apple.com>
+
+ Windows specific implementation of usesTileCacheLayer needed after r133056.
+ https://bugs.webkit.org/show_bug.cgi?id=103321
+
+ Reviewed by Simon Fraser.
+
+ After r133056 it no longer suffices to use the existing usesTileCacheLayer method on Windows.
+ The change resulted in 3 crashing tests:
+ compositing/rotated-tiled-clamped
+ compositing/rotated-tiled-preserve3d-clamped
+ fast/events/tabindex-focus-blur-all
+
+ * platform/win/TestExpectations:
+ Remove the tests below from the Windows skip list.
+
+ * platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
+ * platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
+ Add Windows specific results for tests added in r133056.
+
2012-11-27 Thiago Marcos P. Santos <thiago.san...@intel.com>
[EFL] Gardening of failing tests
Modified: trunk/LayoutTests/platform/win/TestExpectations (135889 => 135890)
--- trunk/LayoutTests/platform/win/TestExpectations 2012-11-27 19:31:39 UTC (rev 135889)
+++ trunk/LayoutTests/platform/win/TestExpectations 2012-11-27 19:34:40 UTC (rev 135890)
@@ -2438,7 +2438,3 @@
# ACCELERATED_OVERFLOW_SCROLLING is disabled on Windows
compositing/overflow/scrolling-without-painting.html
compositing/overflow/updating-scrolling-content.html
-
-# Skip some compositing/tiling tests after r133056
-compositing/tiling/rotated-tiled-preserve3d-clamped.html
-compositing/tiling/rotated-tiled-clamped.html
Added: trunk/LayoutTests/platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt (0 => 135890)
--- trunk/LayoutTests/platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt 2012-11-27 19:34:40 UTC (rev 135890)
@@ -0,0 +1,37 @@
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (visible rect 0.00, 0.00 800.00 x 600.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 800.00 600.00)
+ (visible rect 0.00, 0.00 800.00 x 600.00)
+ (children 1
+ (GraphicsLayer
+ (position 58.00 50.00)
+ (bounds 502.00 302.00)
+ (visible rect 0.00, 0.00 502.00 x 302.00)
+ (children 1
+ (GraphicsLayer
+ (position 1.00 1.00)
+ (bounds 500.00 300.00)
+ (childrenTransform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 -0.00] [0.00 0.00 0.00 1.00])
+ (visible rect 0.00, 0.00 500.00 x 300.00)
+ (children 1
+ (GraphicsLayer
+ (position -1250.00 0.00)
+ (anchor 0.54 0.50)
+ (bounds 2800.00 300.00)
+ (usingTiledLayer 1)
+ (drawsContent 1)
+ (transform [0.17 0.00 -0.98 0.00] [0.00 1.00 0.00 0.00] [0.98 0.00 0.17 0.00] [0.00 0.00 0.00 1.00])
+ (visible rect 0.00, 0.00 2800.00 x 300.00)
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+)
+
Added: trunk/LayoutTests/platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt (0 => 135890)
--- trunk/LayoutTests/platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt 2012-11-27 19:34:40 UTC (rev 135890)
@@ -0,0 +1,44 @@
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (visible rect 0.00, 0.00 800.00 x 600.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 800.00 600.00)
+ (visible rect 0.00, 0.00 800.00 x 600.00)
+ (children 1
+ (GraphicsLayer
+ (position 58.00 50.00)
+ (bounds 502.00 302.00)
+ (visible rect 0.00, 0.00 502.00 x 302.00)
+ (children 1
+ (GraphicsLayer
+ (position 1.00 1.00)
+ (bounds 500.00 300.00)
+ (childrenTransform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 -0.00] [0.00 0.00 0.00 1.00])
+ (visible rect 0.00, 0.00 500.00 x 300.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 500.00 0.00)
+ (preserves3D 1)
+ (visible rect 0.00, 0.00 0.00 x 0.00)
+ (children 1
+ (GraphicsLayer
+ (position -1250.00 0.00)
+ (anchor 0.54 0.50)
+ (bounds 2800.00 300.00)
+ (usingTiledLayer 1)
+ (drawsContent 1)
+ (transform [0.17 0.00 -0.98 0.00] [0.00 1.00 0.00 0.00] [0.98 0.00 0.17 0.00] [0.00 0.00 0.00 1.00])
+ (visible rect 0.00, 0.00 2800.00 x 300.00)
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+)
+
Modified: trunk/Source/WebCore/ChangeLog (135889 => 135890)
--- trunk/Source/WebCore/ChangeLog 2012-11-27 19:31:39 UTC (rev 135889)
+++ trunk/Source/WebCore/ChangeLog 2012-11-27 19:34:40 UTC (rev 135890)
@@ -1,3 +1,21 @@
+2012-11-27 Roger Fong <roger_f...@apple.com>
+
+ Windows specific implementation of usesTileCacheLayer needed after r133056.
+ https://bugs.webkit.org/show_bug.cgi?id=103321
+
+ Reviewed by Simon Fraser.
+
+ After r133056 it no longer suffices to use the existing usesTileCacheLayer method on Windows.
+ The change resulted in 3 crashing tests:
+ compositing/rotated-tiled-clamped
+ compositing/rotated-tiled-preserve3d-clamped
+ fast/events/tabindex-focus-blur-all
+
+ * platform/graphics/ca/PlatformCALayer.h:
+ (WebCore::PlatformCALayer::usesTileCacheLayer):
+ (PlatformCALayer):
+ Adding in platform specific method for Windows that returns false for this method.
+
2012-11-27 Christophe Dumez <christophe.du...@intel.com>
Canvas does not draw any text if the font is not fully loaded yet
Modified: trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h (135889 => 135890)
--- trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2012-11-27 19:31:39 UTC (rev 135889)
+++ trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h 2012-11-27 19:34:40 UTC (rev 135890)
@@ -80,7 +80,11 @@
PlatformLayer* platformLayer() const;
+#if PLATFORM(WIN)
+ bool usesTileCacheLayer() const { return false; }
+#elif
bool usesTileCacheLayer() const { return m_layerType == LayerTypePageTileCacheLayer || m_layerType == LayerTypeTileCacheLayer; }
+#endif
PlatformCALayer* rootLayer() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
