Title: [136573] trunk/Source/WebCore
- Revision
- 136573
- Author
- dpra...@chromium.org
- Date
- 2012-12-04 14:42:23 -0800 (Tue, 04 Dec 2012)
Log Message
createRareData should return a PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=103851
Patch by Elliott Sprehn <espr...@chromium.org> on 2012-12-04
Reviewed by Eric Seidel.
createRareData should return a PassOwnPtr, not an OwnPtr since it's
transfering ownership.
* dom/Element.cpp:
(WebCore::Element::createRareData):
* dom/Element.h:
(Element):
* dom/Node.cpp:
(WebCore::Node::createRareData):
* dom/Node.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (136572 => 136573)
--- trunk/Source/WebCore/ChangeLog 2012-12-04 22:30:28 UTC (rev 136572)
+++ trunk/Source/WebCore/ChangeLog 2012-12-04 22:42:23 UTC (rev 136573)
@@ -1,3 +1,21 @@
+2012-12-04 Elliott Sprehn <espr...@chromium.org>
+
+ createRareData should return a PassOwnPtr
+ https://bugs.webkit.org/show_bug.cgi?id=103851
+
+ Reviewed by Eric Seidel.
+
+ createRareData should return a PassOwnPtr, not an OwnPtr since it's
+ transfering ownership.
+
+ * dom/Element.cpp:
+ (WebCore::Element::createRareData):
+ * dom/Element.h:
+ (Element):
+ * dom/Node.cpp:
+ (WebCore::Node::createRareData):
+ * dom/Node.h:
+
2012-12-04 Filip Pizlo <fpi...@apple.com>
Rename Profiler to LegacyProfiler
Modified: trunk/Source/WebCore/dom/Element.cpp (136572 => 136573)
--- trunk/Source/WebCore/dom/Element.cpp 2012-12-04 22:30:28 UTC (rev 136572)
+++ trunk/Source/WebCore/dom/Element.cpp 2012-12-04 22:42:23 UTC (rev 136573)
@@ -207,8 +207,8 @@
{
return static_cast<ElementRareData*>(ensureRareData());
}
-
-OwnPtr<NodeRareData> Element::createRareData()
+
+PassOwnPtr<NodeRareData> Element::createRareData()
{
return adoptPtr(new ElementRareData(documentInternal()));
}
Modified: trunk/Source/WebCore/dom/Element.h (136572 => 136573)
--- trunk/Source/WebCore/dom/Element.h 2012-12-04 22:30:28 UTC (rev 136572)
+++ trunk/Source/WebCore/dom/Element.h 2012-12-04 22:42:23 UTC (rev 136573)
@@ -540,7 +540,7 @@
virtual PassRefPtr<Element> cloneElementWithoutAttributesAndChildren();
QualifiedName m_tagName;
- virtual OwnPtr<NodeRareData> createRareData();
+ virtual PassOwnPtr<NodeRareData> createRareData();
bool rareDataStyleAffectedByEmpty() const;
bool rareDataChildrenAffectedByHover() const;
bool rareDataChildrenAffectedByActive() const;
Modified: trunk/Source/WebCore/dom/Node.cpp (136572 => 136573)
--- trunk/Source/WebCore/dom/Node.cpp 2012-12-04 22:30:28 UTC (rev 136572)
+++ trunk/Source/WebCore/dom/Node.cpp 2012-12-04 22:42:23 UTC (rev 136573)
@@ -466,7 +466,7 @@
return data;
}
-OwnPtr<NodeRareData> Node::createRareData()
+PassOwnPtr<NodeRareData> Node::createRareData()
{
return adoptPtr(new NodeRareData(documentInternal()));
}
Modified: trunk/Source/WebCore/dom/Node.h (136572 => 136573)
--- trunk/Source/WebCore/dom/Node.h 2012-12-04 22:30:28 UTC (rev 136572)
+++ trunk/Source/WebCore/dom/Node.h 2012-12-04 22:42:23 UTC (rev 136573)
@@ -793,7 +793,7 @@
virtual void refEventTarget();
virtual void derefEventTarget();
- virtual OwnPtr<NodeRareData> createRareData();
+ virtual PassOwnPtr<NodeRareData> createRareData();
bool rareDataFocused() const;
virtual RenderStyle* nonRendererStyle() const { return 0; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
