Title: [136848] trunk/Tools
Revision
136848
Author
[email protected]
Date
2012-12-06 09:43:33 -0800 (Thu, 06 Dec 2012)

Log Message

[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
https://bugs.webkit.org/show_bug.cgi?id=104139

Patch by Yael Aharon <[email protected]> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Resize the window back to 800x600 between tests.
This should be a no-op if the test did not resize the window.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (136847 => 136848)


--- trunk/Tools/ChangeLog	2012-12-06 17:07:02 UTC (rev 136847)
+++ trunk/Tools/ChangeLog	2012-12-06 17:43:33 UTC (rev 136848)
@@ -1,3 +1,16 @@
+2012-12-06  Yael Aharon  <[email protected]>
+
+        [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
+        https://bugs.webkit.org/show_bug.cgi?id=104139
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Resize the window back to 800x600 between tests.
+        This should be a no-op if the test did not resize the window.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetStateToConsistentValues):
+
 2012-12-06  Tommy Widenflycht  <[email protected]>
 
         Speech Recognition API: Change the error code to a string on SpeechRecognitionError

Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (136847 => 136848)


--- trunk/Tools/WebKitTestRunner/TestController.cpp	2012-12-06 17:07:02 UTC (rev 136847)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2012-12-06 17:43:33 UTC (rev 136848)
@@ -564,6 +564,13 @@
     // Re-set to the default backing scale factor by setting the custom scale factor to 0.
     WKPageSetCustomBackingScaleFactor(m_mainWebView->page(), 0);
 
+#if PLATFORM(EFL)
+    // EFL use a real window while other ports such as Qt don't.
+    // In EFL, we need to resize the window to the original size after calls to window.resizeTo.
+    WKRect rect = m_mainWebView->windowFrame();
+    m_mainWebView->setWindowFrame(WKRectMake(rect.origin.x, rect.origin.y, 800, 600));
+#endif
+
     // Reset notification permissions
     m_webNotificationProvider.reset();
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to