Title: [137300] trunk
- Revision
- 137300
- Author
- mrobin...@webkit.org
- Date
- 2012-12-11 05:53:14 -0800 (Tue, 11 Dec 2012)
Log Message
[Coverity] [GTK] Remove some redundant null checks in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=104570
Reviewed by Daniel Bates.
Source/WebKit/gtk:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId): Remove a redundant null check.
Tools:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(descriptionSuitableForTestResult): Remove a redundant null check.
Modified Paths
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (137299 => 137300)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-12-11 13:39:07 UTC (rev 137299)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-12-11 13:53:14 UTC (rev 137300)
@@ -1,3 +1,13 @@
+2012-12-11 Martin Robinson <mrobin...@igalia.com>
+
+ [Coverity] [GTK] Remove some redundant null checks in DumpRenderTree
+ https://bugs.webkit.org/show_bug.cgi?id=104570
+
+ Reviewed by Daniel Bates.
+
+ * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+ (DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId): Remove a redundant null check.
+
2012-12-10 Carlos Garcia Campos <cgar...@igalia.com>
[GTK] Build GObject DOM bindings as a separate library
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (137299 => 137300)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2012-12-11 13:39:07 UTC (rev 137299)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2012-12-11 13:53:14 UTC (rev 137300)
@@ -738,9 +738,6 @@
return false;
HTMLInputElement* inputElement = static_cast<HTMLInputElement*>(coreNode);
- if (!inputElement)
- return false;
-
return inputElement->isTextField() && !inputElement->isPasswordField() && inputElement->shouldAutocomplete();
}
Modified: trunk/Tools/ChangeLog (137299 => 137300)
--- trunk/Tools/ChangeLog 2012-12-11 13:39:07 UTC (rev 137299)
+++ trunk/Tools/ChangeLog 2012-12-11 13:53:14 UTC (rev 137300)
@@ -1,3 +1,13 @@
+2012-12-11 Martin Robinson <mrobin...@igalia.com>
+
+ [Coverity] [GTK] Remove some redundant null checks in DumpRenderTree
+ https://bugs.webkit.org/show_bug.cgi?id=104570
+
+ Reviewed by Daniel Bates.
+
+ * DumpRenderTree/gtk/DumpRenderTree.cpp:
+ (descriptionSuitableForTestResult): Remove a redundant null check.
+
2012-12-11 Alberto Garcia <agar...@igalia.com>
Remove unused GErrors
Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (137299 => 137300)
--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2012-12-11 13:39:07 UTC (rev 137299)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2012-12-11 13:53:14 UTC (rev 137300)
@@ -1231,8 +1231,7 @@
CString mainDocumentURIString(descriptionSuitableForTestResult(mainDocumentURI));
CString path(convertNetworkRequestToURLPath(request));
GOwnPtr<char> description(g_strdup_printf("<NSURLRequest URL %s, main document URL %s, http method %s>",
- path.data(), mainDocumentURIString.data(),
- soupMessage ? soupMessage->method : "(none)"));
+ path.data(), mainDocumentURIString.data(), soupMessage->method));
return CString(description.get());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
