Title: [138016] trunk/Source/WebCore
- Revision
- 138016
- Author
- commit-qu...@webkit.org
- Date
- 2012-12-18 07:01:02 -0800 (Tue, 18 Dec 2012)
Log Message
Web Inspector: [Network] Ordering of cookies displayed is nondeterministic.
https://bugs.webkit.org/show_bug.cgi?id=105272
Patch by Eugene Klyuchnikov <eus...@chromium.org> on 2012-12-18
Reviewed by Vsevolod Vlasov.
This patch fixes double-selection of request and sets default ordering
of cookies.
* inspector/front-end/CookiesTable.js: By default sort by name.
* inspector/front-end/NetworkPanel.js: Do not fire "select" on
mouse-click in viewing-request mode.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (138015 => 138016)
--- trunk/Source/WebCore/ChangeLog 2012-12-18 14:42:31 UTC (rev 138015)
+++ trunk/Source/WebCore/ChangeLog 2012-12-18 15:01:02 UTC (rev 138016)
@@ -1,3 +1,17 @@
+2012-12-18 Eugene Klyuchnikov <eus...@chromium.org>
+
+ Web Inspector: [Network] Ordering of cookies displayed is nondeterministic.
+ https://bugs.webkit.org/show_bug.cgi?id=105272
+
+ Reviewed by Vsevolod Vlasov.
+
+ This patch fixes double-selection of request and sets default ordering
+ of cookies.
+
+ * inspector/front-end/CookiesTable.js: By default sort by name.
+ * inspector/front-end/NetworkPanel.js: Do not fire "select" on
+ mouse-click in viewing-request mode.
+
2012-12-18 Alexander Pavlov <apav...@chromium.org>
Unreviewed, rolling out r138011.
Modified: trunk/Source/WebCore/inspector/front-end/CookiesTable.js (138015 => 138016)
--- trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2012-12-18 14:42:31 UTC (rev 138015)
+++ trunk/Source/WebCore/inspector/front-end/CookiesTable.js 2012-12-18 15:01:02 UTC (rev 138016)
@@ -45,6 +45,7 @@
columns[0].sortable = true;
columns[0].disclosure = expandable;
columns[0].width = "24%";
+ columns[0].sort = "ascending";
columns[1].title = WebInspector.UIString("Value");
columns[1].sortable = true;
columns[1].width = "34%";
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (138015 => 138016)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-12-18 14:42:31 UTC (rev 138015)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-12-18 15:01:02 UTC (rev 138016)
@@ -1846,7 +1846,7 @@
this._sizeCell = this._createDivInTD("size");
this._timeCell = this._createDivInTD("time");
this._createTimelineCell();
- this._nameCell.addEventListener("click", this.select.bind(this), false);
+ this._nameCell.addEventListener("click", this._onClick.bind(this), false);
this._nameCell.addEventListener("dblclick", this._openInNewTab.bind(this), false);
},
@@ -1859,6 +1859,12 @@
return this._request.type.name() in this._parentView._hiddenCategories;
},
+ _onClick: function()
+ {
+ if (!this._parentView._allowRequestSelection)
+ this.select();
+ },
+
select: function()
{
this._parentView.dispatchEventToListeners(WebInspector.NetworkLogView.EventTypes.RequestSelected, this._request);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
