Title: [138205] trunk/Source/_javascript_Core
Revision
138205
Author
oli...@apple.com
Date
2012-12-19 16:50:48 -0800 (Wed, 19 Dec 2012)

Log Message

Fix some incorrect tests in testapi.c

Modified Paths


Diff

Modified: trunk/Source/_javascript_Core/API/tests/testapi.c (138204 => 138205)


--- trunk/Source/_javascript_Core/API/tests/testapi.c	2012-12-20 00:40:01 UTC (rev 138204)
+++ trunk/Source/_javascript_Core/API/tests/testapi.c	2012-12-20 00:50:48 UTC (rev 138205)
@@ -1634,8 +1634,8 @@
         JSStringRef errorMessage = 0;
         int errorLine = 0;
         JSScriptRef scriptObject = JSScriptCreateFromString(contextGroup, url, 1, script, &errorMessage, &errorLine);
-        ASSERT((!scriptObject) != (!exception));
-        if (exception) {
+        ASSERT((!scriptObject) != (!errorMessage));
+        if (!scriptObject) {
             printf("FAIL: Test script did not parse\n\t%s:%d\n\t", scriptPath, errorLine);
             CFStringRef errorCF = JSStringCopyCFString(kCFAllocatorDefault, errorMessage);
             CFShow(errorCF);

Modified: trunk/Source/_javascript_Core/ChangeLog (138204 => 138205)


--- trunk/Source/_javascript_Core/ChangeLog	2012-12-20 00:40:01 UTC (rev 138204)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-12-20 00:50:48 UTC (rev 138205)
@@ -1,3 +1,12 @@
+2012-12-19  Oliver Hunt  <oli...@apple.com>
+
+        Fix some incorrect tests in testapi.c
+
+        Reviewed by Simon Fraser.
+
+        * API/tests/testapi.c:
+        (main):
+
 2012-12-19  Filip Pizlo  <fpi...@apple.com>
 
         JSObject::ensure<IndexingType> should gracefully handle InterceptsGetOwn..., and should never be called when the 'this' is not an object
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to