Title: [138431] trunk/Source/WebKit/blackberry
- Revision
- 138431
- Author
- [email protected]
- Date
- 2012-12-23 20:43:23 -0800 (Sun, 23 Dec 2012)
Log Message
[BlackBerry] give url when createWindow
https://bugs.webkit.org/show_bug.cgi?id=105702
RIM bug# 257329
Reviewed by George Staikos.
This is to revert previous commit 575407238c35f1a0fa7ff7dd5dbbf6cc3ece1107
for integration issue of cascade and air, as old app side still use the url
to invoke. It would unrevert after resolving the integration issue.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (138430 => 138431)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-12-24 04:38:02 UTC (rev 138430)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-12-24 04:43:23 UTC (rev 138431)
@@ -1,3 +1,18 @@
+2012-12-23 Mary Wu <[email protected]>
+
+ [BlackBerry] give url when createWindow
+ https://bugs.webkit.org/show_bug.cgi?id=105702
+ RIM bug# 257329
+
+ Reviewed by George Staikos.
+
+ This is to revert previous commit 575407238c35f1a0fa7ff7dd5dbbf6cc3ece1107
+ for integration issue of cascade and air, as old app side still use the url
+ to invoke. It would unrevert after resolving the integration issue.
+
+ * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+ (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
+
2012-12-23 Jakob Petsovits <[email protected]>
[BlackBerry] Specify tile usage enum for backingstore tiles.
@@ -1175,26 +1190,6 @@
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
-2012-12-07 Mary Wu <[email protected]>
-
- [BlackBerry] new target window would cause the url being loaded twice
- https://bugs.webkit.org/show_bug.cgi?id=104086
-
- Reviewed by Yong Li.
-
- When webkit need to open window for a new target like "_blank", it would
- load the url subsequently after createWindow. But the chrome browser would
- load the url again when it get the OpenWindowEvent from native, which
- causes the url being loaded twice. We should make sure that createWindow() be
- used to create a new window only, not loading url, so we pass empty url
- as parameter.
-
- RIM PR# 257329
- Internally reviewed by Charles Wei.
-
- * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
-
2012-12-05 Otto Derek Cheung <[email protected]>
[BlackBerry] Geolocation prompts won't respond to the correct geolocation object if the user opens two pages and respond in the reversed order
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (138430 => 138431)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-12-24 04:38:02 UTC (rev 138430)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-12-24 04:43:23 UTC (rev 138431)
@@ -967,8 +967,7 @@
Frame* FrameLoaderClientBlackBerry::dispatchCreatePage(const NavigationAction& navigation)
{
- UNUSED_PARAM(navigation);
- WebPage* webPage = m_webPagePrivate->m_client->createWindow(0, 0, -1, -1, WebPageClient::FlagWindowDefault, BlackBerry::Platform::String::emptyString(), BlackBerry::Platform::String::emptyString());
+ WebPage* webPage = m_webPagePrivate->m_client->createWindow(0, 0, -1, -1, WebPageClient::FlagWindowDefault, navigation.url().string(), BlackBerry::Platform::String::emptyString());
if (!webPage)
return 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes