Title: [138733] trunk/Tools
- Revision
- 138733
- Author
- [email protected]
- Date
- 2013-01-03 13:30:32 -0800 (Thu, 03 Jan 2013)
Log Message
Add unit test for default builder for the dashboards.
https://bugs.webkit.org/show_bug.cgi?id=105972
Reviewed by Dirk Pranke.
* TestResultServer/static-dashboards/loader_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (138732 => 138733)
--- trunk/Tools/ChangeLog 2013-01-03 21:26:44 UTC (rev 138732)
+++ trunk/Tools/ChangeLog 2013-01-03 21:30:32 UTC (rev 138733)
@@ -1,3 +1,12 @@
+2013-01-03 Julie Parent <[email protected]>
+
+ Add unit test for default builder for the dashboards.
+ https://bugs.webkit.org/show_bug.cgi?id=105972
+
+ Reviewed by Dirk Pranke.
+
+ * TestResultServer/static-dashboards/loader_unittests.js:
+
2013-01-03 Tony Chang <[email protected]>
Generate internal.settings from Settings.in
Modified: trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js (138732 => 138733)
--- trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js 2013-01-03 21:26:44 UTC (rev 138732)
+++ trunk/Tools/TestResultServer/static-dashboards/loader_unittests.js 2013-01-03 21:30:32 UTC (rev 138733)
@@ -134,3 +134,19 @@
equal(resourceLoadCount, 2);
});
+
+test('Default builder gets set.', 3, function() {
+ resetGlobals();
+ loadBuildersList('@ToT - chromium.org', 'layout-tests');
+
+ var defaultBuilder = g_defaultBuilderName;
+ ok(defaultBuilder, "Default builder should exist.");
+
+ // Simulate error loading the default builder data, then make sure
+ // a new defaultBuilder is set, and isn't the now invalid one.
+ var resourceLoader = new loader.Loader();
+ resourceLoader._handleResultsFileLoadError(defaultBuilder);
+ var newDefaultBuilder = g_defaultBuilderName;
+ ok(newDefaultBuilder, "There should still be a default builder.");
+ notEqual(newDefaultBuilder, defaultBuilder, "Default builder should not be the old default builder");
+});
\ No newline at end of file
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
