Title: [138768] trunk/Websites/bugs.webkit.org
Revision
138768
Author
commit-qu...@webkit.org
Date
2013-01-03 17:06:19 -0800 (Thu, 03 Jan 2013)

Log Message

Avoid mixed content when expanding context in code review tool
https://bugs.webkit.org/show_bug.cgi?id=106060

Patch by James Robinson <jam...@chromium.org> on 2013-01-03
Reviewed by Tony Chang.

Example failure: "The page at https://bugs.webkit.org/attachment.cgi?id=181222&action="" displayed insecure
content from http://svn.webkit.org/repository/webkit/trunk/Source/WebCore/page/EventHandler.cpp?p=138617." This
loads from "//svn.webkit.org/..." so the protocol matches.

* code-review.js:

Modified Paths

Diff

Modified: trunk/Websites/bugs.webkit.org/ChangeLog (138767 => 138768)


--- trunk/Websites/bugs.webkit.org/ChangeLog	2013-01-04 00:46:57 UTC (rev 138767)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2013-01-04 01:06:19 UTC (rev 138768)
@@ -1,3 +1,16 @@
+2013-01-03  James Robinson  <jam...@chromium.org>
+
+        Avoid mixed content when expanding context in code review tool
+        https://bugs.webkit.org/show_bug.cgi?id=106060
+
+        Reviewed by Tony Chang.
+
+        Example failure: "The page at https://bugs.webkit.org/attachment.cgi?id=181222&action="" displayed insecure
+        content from http://svn.webkit.org/repository/webkit/trunk/Source/WebCore/page/EventHandler.cpp?p=138617." This
+        loads from "//svn.webkit.org/..." so the protocol matches.
+
+        * code-review.js:
+
 2013-01-02  Ojan Vafai  <o...@chromium.org>
 
         REGRESSION: Review tool sometimes doesn't include some comments in preview & posts

Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (138767 => 138768)


--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2013-01-04 00:46:57 UTC (rev 138767)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2013-01-04 01:06:19 UTC (rev 138768)
@@ -506,7 +506,7 @@
 }
 </style>
 <script src="" 
-<script src=""
+<script src=""
 </head>
 EOF
 

Modified: trunk/Websites/bugs.webkit.org/code-review.js (138767 => 138768)


--- trunk/Websites/bugs.webkit.org/code-review.js	2013-01-04 00:46:57 UTC (rev 138767)
+++ trunk/Websites/bugs.webkit.org/code-review.js	2013-01-04 01:06:19 UTC (rev 138768)
@@ -69,7 +69,7 @@
   var files = {};
   var original_file_contents = {};
   var patched_file_contents = {};
-  var WEBKIT_BASE_DIR = "http://svn.webkit.org/repository/webkit/trunk/";
+  var WEBKIT_BASE_DIR = "//svn.webkit.org/repository/webkit/trunk/";
   var SIDE_BY_SIDE_DIFFS_KEY = 'sidebysidediffs';
   var g_displayed_draft_comments = false;
   var g_next_line_id = 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to