Diff
Modified: trunk/LayoutTests/ChangeLog (138807 => 138808)
--- trunk/LayoutTests/ChangeLog 2013-01-04 17:47:54 UTC (rev 138807)
+++ trunk/LayoutTests/ChangeLog 2013-01-04 17:58:11 UTC (rev 138808)
@@ -1,3 +1,19 @@
+2013-01-04 Rick Byers <rby...@chromium.org>
+
+ Existence of window.Touch can break websites mobile device detection
+ https://bugs.webkit.org/show_bug.cgi?id=106071
+
+ Revert http://trac.webkit.org/changeset/135562 for now while I work
+ on a slightly safer version.
+
+ Reviewed by Ojan Vafai.
+
+ * fast/events/touch/document-create-touch-list-expected.txt:
+ * fast/events/touch/script-tests/document-create-touch-list.js:
+ * platform/efl/fast/js/global-constructors-expected.txt:
+ * platform/qt-5.0/fast/js/global-constructors-expected.txt:
+ * platform/qt/fast/js/global-constructors-expected.txt:
+
2013-01-04 Csaba Osztrogonác <o...@webkit.org>
[Qt][WK2] Unreviewed gardening, unskip a now passing test.
Modified: trunk/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt (138807 => 138808)
--- trunk/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt 2013-01-04 17:47:54 UTC (rev 138807)
+++ trunk/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt 2013-01-04 17:58:11 UTC (rev 138808)
@@ -9,10 +9,7 @@
PASS touchList.item(0) is null
PASS touchList.item(1) is null
PASS touchList.item() threw exception TypeError: Not enough arguments.
-PASS ts instanceof TouchEvent is true
-PASS ts.touches instanceof TouchList is true
PASS ts.touches.length is 2
-PASS ts.touches[0] instanceof Touch is true
PASS ts.touches[0].identifier is 12341
PASS ts.touches[0].clientX is 60
PASS ts.touches[1].screenY is 120
Modified: trunk/LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js (138807 => 138808)
--- trunk/LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js 2013-01-04 17:47:54 UTC (rev 138807)
+++ trunk/LayoutTests/fast/events/touch/script-tests/document-create-touch-list.js 2013-01-04 17:58:11 UTC (rev 138808)
@@ -21,10 +21,7 @@
document.body.addEventListener("touchstart", function handleTouchStart(ev) {
ts = ev;
- shouldBeTrue("ts instanceof TouchEvent");
- shouldBeTrue("ts.touches instanceof TouchList");
shouldBe("ts.touches.length", "2");
- shouldBeTrue("ts.touches[0] instanceof Touch");
shouldBe("ts.touches[0].identifier", "12341");
shouldBe("ts.touches[0].clientX", "60");
shouldBe("ts.touches[1].screenY", "120");
Modified: trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt (138807 => 138808)
--- trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt 2013-01-04 17:47:54 UTC (rev 138807)
+++ trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt 2013-01-04 17:58:11 UTC (rev 138808)
@@ -322,9 +322,7 @@
PASS TextTrackCueList.toString() is '[object TextTrackCueListConstructor]'
PASS TextTrackList.toString() is '[object TextTrackListConstructor]'
PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
-PASS Touch.toString() is '[object TouchConstructor]'
PASS TouchEvent.toString() is '[object TouchEventConstructor]'
-PASS TouchList.toString() is '[object TouchListConstructor]'
PASS TrackEvent.toString() is '[object TrackEventConstructor]'
PASS UIEvent.toString() is '[object UIEventConstructor]'
PASS URL.toString() is '[object URLConstructor]'
Modified: trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt (138807 => 138808)
--- trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt 2013-01-04 17:47:54 UTC (rev 138807)
+++ trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt 2013-01-04 17:58:11 UTC (rev 138808)
@@ -295,9 +295,7 @@
PASS TextEvent.toString() is '[object TextEventConstructor]'
PASS TextMetrics.toString() is '[object TextMetricsConstructor]'
PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
-PASS Touch.toString() is '[object TouchConstructor]'
PASS TouchEvent.toString() is '[object TouchEventConstructor]'
-PASS TouchList.toString() is '[object TouchListConstructor]'
PASS UIEvent.toString() is '[object UIEventConstructor]'
PASS WebGLContextEvent.toString() is '[object WebGLContextEventConstructor]'
PASS WebKitAnimationEvent.toString() is '[object WebKitAnimationEventConstructor]'
Modified: trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt (138807 => 138808)
--- trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt 2013-01-04 17:47:54 UTC (rev 138807)
+++ trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt 2013-01-04 17:58:11 UTC (rev 138808)
@@ -312,9 +312,7 @@
PASS TextEvent.toString() is '[object TextEventConstructor]'
PASS TextMetrics.toString() is '[object TextMetricsConstructor]'
PASS TimeRanges.toString() is '[object TimeRangesConstructor]'
-PASS Touch.toString() is '[object TouchConstructor]'
PASS TouchEvent.toString() is '[object TouchEventConstructor]'
-PASS TouchList.toString() is '[object TouchListConstructor]'
PASS UIEvent.toString() is '[object UIEventConstructor]'
PASS URL.toString() is '[object URLConstructor]'
PASS WebGLContextEvent.toString() is '[object WebGLContextEventConstructor]'
Modified: trunk/Source/WebCore/ChangeLog (138807 => 138808)
--- trunk/Source/WebCore/ChangeLog 2013-01-04 17:47:54 UTC (rev 138807)
+++ trunk/Source/WebCore/ChangeLog 2013-01-04 17:58:11 UTC (rev 138808)
@@ -1,3 +1,15 @@
+2013-01-04 Rick Byers <rby...@chromium.org>
+
+ Existence of window.Touch can break websites mobile device detection
+ https://bugs.webkit.org/show_bug.cgi?id=106071
+
+ Reviewed by Ojan Vafai.
+
+ Revert http://trac.webkit.org/changeset/135562 for now while I work
+ on a slightly safer version.
+
+ * page/DOMWindow.idl:
+
2013-01-04 Martin Robinson <mrobin...@igalia.com>
[GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
Modified: trunk/Source/WebCore/page/DOMWindow.idl (138807 => 138808)
--- trunk/Source/WebCore/page/DOMWindow.idl 2013-01-04 17:47:54 UTC (rev 138807)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2013-01-04 17:58:11 UTC (rev 138808)
@@ -556,9 +556,7 @@
attribute XMLHttpRequestProgressEventConstructor XMLHttpRequestProgressEvent;
[Conditional=DEVICE_ORIENTATION, V8EnabledAtRuntime] attribute DeviceMotionEventConstructor DeviceMotionEvent;
[Conditional=DEVICE_ORIENTATION, V8EnabledAtRuntime] attribute DeviceOrientationEventConstructor DeviceOrientationEvent;
- [Conditional=TOUCH_EVENTS] attribute TouchConstructor Touch;
[Conditional=TOUCH_EVENTS] attribute TouchEventConstructor TouchEvent;
- [Conditional=TOUCH_EVENTS] attribute TouchListConstructor TouchList;
attribute StorageEventConstructor StorageEvent;
[Conditional=INPUT_SPEECH] attribute SpeechInputEventConstructor SpeechInputEvent;
[Conditional=WEBGL] attribute WebGLContextEventConstructor WebGLContextEvent;
