Title: [138865] trunk/Source/WebKit/win
Revision
138865
Author
roger_f...@apple.com
Date
2013-01-04 16:18:50 -0800 (Fri, 04 Jan 2013)

Log Message

Make private browsing work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=106032.

Reviewed by Alexey Proskuryakov.

Code path never called ensurePrivateBrowsingSession which is what starts up the private browsing session.
This was causing many tests to involving private browsing to fail.

* WebView.cpp:
(WebView::notifyPreferencesChanged):

Modified Paths

Diff

Modified: trunk/Source/WebKit/win/ChangeLog (138864 => 138865)


--- trunk/Source/WebKit/win/ChangeLog	2013-01-04 23:57:44 UTC (rev 138864)
+++ trunk/Source/WebKit/win/ChangeLog	2013-01-05 00:18:50 UTC (rev 138865)
@@ -1,3 +1,16 @@
+2013-01-04  Roger Fong  <roger_f...@apple.com>
+
+        Make private browsing work on Windows.
+        https://bugs.webkit.org/show_bug.cgi?id=106032.
+
+        Reviewed by Alexey Proskuryakov.
+
+        Code path never called ensurePrivateBrowsingSession which is what starts up the private browsing session.
+        This was causing many tests to involving private browsing to fail.
+
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
 2013-01-03  Roger Fong  <roger_f...@apple.com>
 
         Remove all traces of Windows from WebKit2 folder.

Modified: trunk/Source/WebKit/win/WebView.cpp (138864 => 138865)


--- trunk/Source/WebKit/win/WebView.cpp	2013-01-04 23:57:44 UTC (rev 138864)
+++ trunk/Source/WebKit/win/WebView.cpp	2013-01-05 00:18:50 UTC (rev 138865)
@@ -4680,6 +4680,12 @@
     hr = preferences->privateBrowsingEnabled(&enabled);
     if (FAILED(hr))
         return hr;
+#if PLATFORM(WIN) || USE(CFNETWORK)
+    if (enabled)
+        WebFrameNetworkingContext::ensurePrivateBrowsingSession();
+    else
+        WebFrameNetworkingContext::destroyPrivateBrowsingSession();
+#endif
     settings->setPrivateBrowsingEnabled(!!enabled);
 
     hr = preferences->sansSerifFontFamily(&str);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to