Title: [138951] trunk/Tools
- Revision
- 138951
- Author
- [email protected]
- Date
- 2013-01-07 09:15:19 -0800 (Mon, 07 Jan 2013)
Log Message
[Qt] run-webkit-tests cleanup for parallel NRWT
https://bugs.webkit.org/show_bug.cgi?id=106220
Reviewed by Dirk Pranke.
* Scripts/run-webkit-tests:
(useNewRunWebKitTests):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.default_child_processes):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (138950 => 138951)
--- trunk/Tools/ChangeLog 2013-01-07 17:02:41 UTC (rev 138950)
+++ trunk/Tools/ChangeLog 2013-01-07 17:15:19 UTC (rev 138951)
@@ -1,3 +1,16 @@
+2013-01-07 Csaba Osztrogonác <[email protected]>
+
+ [Qt] run-webkit-tests cleanup for parallel NRWT
+ https://bugs.webkit.org/show_bug.cgi?id=106220
+
+ Reviewed by Dirk Pranke.
+
+ * Scripts/run-webkit-tests:
+ (useNewRunWebKitTests):
+ * Scripts/webkitpy/layout_tests/port/qt.py:
+ (QtPort):
+ (QtPort.default_child_processes):
+
2013-01-07 Philippe Normand <[email protected]>
Create a GStreamerAudio watchlist and add myself to it.
Modified: trunk/Tools/Scripts/run-webkit-tests (138950 => 138951)
--- trunk/Tools/Scripts/run-webkit-tests 2013-01-07 17:02:41 UTC (rev 138950)
+++ trunk/Tools/Scripts/run-webkit-tests 2013-01-07 17:15:19 UTC (rev 138951)
@@ -65,20 +65,6 @@
return 1;
}
-sub platformIsReadyForParallelTesting()
-{
- # NRWT is able to run the tests in parallel, ORWT was not.
- # When we run the tests in parallel, tests which (incorrectly)
- # interact with each other can start failing.
- # To reduce the failure burden during the transition individual
- # platforms can opt-in to parallel test execution by default.
-
- # We believe all platforms are ready for default parallel testing except
- # Qt, as Qt runs more than one build-slave per-server.
- # Ossy has asked me to blacklist Qt for now.
- return !isQt();
-}
-
my $script = "perl";
my $harnessName = "old-run-webkit-tests";
@@ -86,12 +72,6 @@
$script = "python";
$harnessName = "new-run-webkit-tests";
- if (!grep(/--child-processes/, @ARGV) and !platformIsReadyForParallelTesting()) {
- push(@ARGV, "--child-processes=1");
- print "Running new-run-webkit-tests with one child process.\n";
- print "For more parallelism, run new-run-webkit-tests directly.\n";
- }
-
if (runningOnBuildBot()) {
push(@ARGV, "--debug-rwt-logging");
}
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (138950 => 138951)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2013-01-07 17:02:41 UTC (rev 138950)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2013-01-07 17:15:19 UTC (rev 138951)
@@ -186,3 +186,6 @@
return False
return result
+ # Qt port is not ready for parallel testing, see https://bugs.webkit.org/show_bug.cgi?id=77730 for details.
+ def default_child_processes(self):
+ return 1
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
