Title: [139193] trunk/Source/WebCore
- Revision
- 139193
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-09 07:38:14 -0800 (Wed, 09 Jan 2013)
Log Message
IndexedDB: Remove ASSERTs that can't assert but result in compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=106442
Patch by Jussi Kukkonen <jussi.kukko...@intel.com> on 2013-01-09
Reviewed by Kentaro Hara.
IDBLevelDBCoding::m_metaDataType has been changed to unsigned
so ASSERT(m_metaDataType >= 0) is no longer useful: the compiler
warnings however create build difficulties at least with EFL.
* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139192 => 139193)
--- trunk/Source/WebCore/ChangeLog 2013-01-09 15:02:47 UTC (rev 139192)
+++ trunk/Source/WebCore/ChangeLog 2013-01-09 15:38:14 UTC (rev 139193)
@@ -1,3 +1,18 @@
+2013-01-09 Jussi Kukkonen <jussi.kukko...@intel.com>
+
+ IndexedDB: Remove ASSERTs that can't assert but result in compiler warnings
+ https://bugs.webkit.org/show_bug.cgi?id=106442
+
+ Reviewed by Kentaro Hara.
+
+ IDBLevelDBCoding::m_metaDataType has been changed to unsigned
+ so ASSERT(m_metaDataType >= 0) is no longer useful: the compiler
+ warnings however create build difficulties at least with EFL.
+
+ * Modules/indexeddb/IDBLevelDBCoding.cpp:
+ (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
+ (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
+
2012-12-29 Ilya Tikhonovsky <loi...@chromium.org>
Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 1/N
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp (139192 => 139193)
--- trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp 2013-01-09 15:02:47 UTC (rev 139192)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp 2013-01-09 15:38:14 UTC (rev 139193)
@@ -1223,14 +1223,12 @@
}
unsigned char ObjectStoreMetaDataKey::metaDataType() const
{
- ASSERT(m_metaDataType >= 0);
return m_metaDataType;
}
int ObjectStoreMetaDataKey::compare(const ObjectStoreMetaDataKey& other)
{
ASSERT(m_objectStoreId >= 0);
- ASSERT(m_metaDataType >= 0);
if (int x = compareInts(m_objectStoreId, other.m_objectStoreId))
return x;
int64_t result = m_metaDataType - other.m_metaDataType;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
