Title: [139270] trunk/Tools
- Revision
- 139270
- Author
- jpar...@chromium.org
- Date
- 2013-01-09 18:35:36 -0800 (Wed, 09 Jan 2013)
Log Message
Dashboard Cleanup: Reload the page as soon as we know we need to.
https://bugs.webkit.org/show_bug.cgi?id=106515
No need to continue parsing all of the data once we know that
we need to do a reload.
Reviewed by Dirk Pranke.
* TestResultServer/static-dashboards/dashboard_base.js:
(parseParameters):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139269 => 139270)
--- trunk/Tools/ChangeLog 2013-01-10 02:29:37 UTC (rev 139269)
+++ trunk/Tools/ChangeLog 2013-01-10 02:35:36 UTC (rev 139270)
@@ -1,3 +1,16 @@
+2013-01-09 Julie Parent <jpar...@chromium.org>
+
+ Dashboard Cleanup: Reload the page as soon as we know we need to.
+ https://bugs.webkit.org/show_bug.cgi?id=106515
+
+ No need to continue parsing all of the data once we know that
+ we need to do a reload.
+
+ Reviewed by Dirk Pranke.
+
+ * TestResultServer/static-dashboards/dashboard_base.js:
+ (parseParameters):
+
2013-01-09 Eric Seidel <e...@webkit.org>
run-perf-tests --chromium-android --profile should show symbols for the kernel
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (139269 => 139270)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-01-10 02:29:37 UTC (rev 139269)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-01-10 02:35:36 UTC (rev 139270)
@@ -321,6 +321,17 @@
var oldDashboardSpecificState = g_currentState;
parseCrossDashboardParameters();
+
+ // Some parameters require loading different JSON files when the value changes. Do a reload.
+ if (Object.keys(oldCrossDashboardState).length) {
+ for (var key in g_crossDashboardState) {
+ if (oldCrossDashboardState[key] != g_crossDashboardState[key] && RELOAD_REQUIRING_PARAMETERS.indexOf(key) != -1) {
+ window.location.reload();
+ return {};
+ }
+ }
+ }
+
parseDashboardSpecificParameters();
parseParameter(queryHashAsMap(), 'builder');
@@ -337,14 +348,6 @@
if (g_currentState.tests)
delete g_currentState.builder;
- // Some parameters require loading different JSON files when the value changes. Do a reload.
- if (Object.keys(oldCrossDashboardState).length) {
- for (var key in g_crossDashboardState) {
- if (oldCrossDashboardState[key] != g_crossDashboardState[key] && RELOAD_REQUIRING_PARAMETERS.indexOf(key) != -1)
- window.location.reload();
- }
- }
-
return dashboardSpecificDiffState;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
