Title: [139272] trunk/Tools
- Revision
- 139272
- Author
- jpar...@chromium.org
- Date
- 2013-01-09 18:50:22 -0800 (Wed, 09 Jan 2013)
Log Message
Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
https://bugs.webkit.org/show_bug.cgi?id=106514
This is old code, as these can no longer get out of sync.
permmaLinkURLHash is generated from currentState, which is set only
from the location. The commment about how these can get out of sync
refers to a function that no longer exists.
Reviewed by Dirk Pranke.
* TestResultServer/static-dashboards/dashboard_base.js:
(handleLocationChange):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139271 => 139272)
--- trunk/Tools/ChangeLog 2013-01-10 02:41:46 UTC (rev 139271)
+++ trunk/Tools/ChangeLog 2013-01-10 02:50:22 UTC (rev 139272)
@@ -1,5 +1,20 @@
2013-01-09 Julie Parent <jpar...@chromium.org>
+ Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
+ https://bugs.webkit.org/show_bug.cgi?id=106514
+
+ This is old code, as these can no longer get out of sync.
+ permmaLinkURLHash is generated from currentState, which is set only
+ from the location. The commment about how these can get out of sync
+ refers to a function that no longer exists.
+
+ Reviewed by Dirk Pranke.
+
+ * TestResultServer/static-dashboards/dashboard_base.js:
+ (handleLocationChange):
+
+2013-01-09 Julie Parent <jpar...@chromium.org>
+
Dashboard Cleanup: Reload the page as soon as we know we need to.
https://bugs.webkit.org/show_bug.cgi?id=106515
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (139271 => 139272)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-01-10 02:41:46 UTC (rev 139271)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-01-10 02:50:22 UTC (rev 139272)
@@ -514,15 +514,7 @@
if (Object.keys(params).length)
shouldGeneratePage = handleQueryParameterChange(params);
- var newHash = permaLinkURLHash();
- var winHash = window.location.hash || "#";
- // Make sure the location is the same as the state we are using internally.
- // These get out of sync if processQueryParamChange changed state.
- if (newHash != winHash) {
- // This will cause another hashchange, and when we loop
- // back through here next time, we'll go through generatePage.
- window.location.hash = newHash;
- } else if (shouldGeneratePage)
+ if (shouldGeneratePage)
generatePage();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
