Title: [139283] trunk/Source/WebCore
- Revision
- 139283
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-09 22:28:45 -0800 (Wed, 09 Jan 2013)
Log Message
Web Inspector: [Network] Data grid header and content cells are misaligned.
https://bugs.webkit.org/show_bug.cgi?id=105795
Patch by Eugene Klyuchnikov <eus...@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.
Header and content tables have different width -> same percent values
turn to different cell widths.
* inspector/front-end/DataGrid.js: Add "corner" cell to all rows.
* inspector/front-end/dataGrid.css: Apply "corner" rules to "td" nodes.
(.data-grid .data-container): Remove artificial padding.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139282 => 139283)
--- trunk/Source/WebCore/ChangeLog 2013-01-10 06:23:32 UTC (rev 139282)
+++ trunk/Source/WebCore/ChangeLog 2013-01-10 06:28:45 UTC (rev 139283)
@@ -1,3 +1,17 @@
+2013-01-09 Eugene Klyuchnikov <eus...@chromium.org>
+
+ Web Inspector: [Network] Data grid header and content cells are misaligned.
+ https://bugs.webkit.org/show_bug.cgi?id=105795
+
+ Reviewed by Pavel Feldman.
+
+ Header and content tables have different width -> same percent values
+ turn to different cell widths.
+
+ * inspector/front-end/DataGrid.js: Add "corner" cell to all rows.
+ * inspector/front-end/dataGrid.css: Apply "corner" rules to "td" nodes.
+ (.data-grid .data-container): Remove artificial padding.
+
2013-01-09 Tien-Ren Chen <trc...@chromium.org>
Make caret repainting container-aware
Modified: trunk/Source/WebCore/inspector/front-end/DataGrid.js (139282 => 139283)
--- trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-01-10 06:23:32 UTC (rev 139282)
+++ trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-01-10 06:28:45 UTC (rev 139283)
@@ -115,9 +115,7 @@
columnGroup.span = this._columnCount;
- var cell = document.createElement("th");
- cell.className = "corner";
- headerRow.appendChild(cell);
+ headerRow.createChild("th", "corner");
this._headerTableColumnGroup = columnGroup;
this._headerTable.appendChild(this._headerTableColumnGroup);
@@ -126,12 +124,9 @@
var fillerRow = document.createElement("tr");
fillerRow.className = "filler";
- for (var columnIdentifier in columns) {
- var column = columns[columnIdentifier];
- var td = document.createElement("td");
- td.className = columnIdentifier + "-column";
- fillerRow.appendChild(td);
- }
+ for (var columnIdentifier in columns)
+ fillerRow.createChild("td", columnIdentifier + "-column");
+ fillerRow.createChild("td", "corner");
this._dataTableColumnGroup = columnGroup.cloneNode(true);
this._dataTable.appendChild(this._dataTableColumnGroup);
@@ -1069,6 +1064,8 @@
this._element.addStyleClass("revealed");
this.createCells();
+ this._element.createChild("td", "corner");
+
return this._element;
},
Modified: trunk/Source/WebCore/inspector/front-end/dataGrid.css (139282 => 139283)
--- trunk/Source/WebCore/inspector/front-end/dataGrid.css 2013-01-10 06:23:32 UTC (rev 139282)
+++ trunk/Source/WebCore/inspector/front-end/dataGrid.css 2013-01-10 06:28:45 UTC (rev 139283)
@@ -26,7 +26,6 @@
bottom: 0;
left: 0;
right: 0;
- padding-right: 14px;
overflow-x: hidden;
overflow-y: overlay;
}
@@ -48,11 +47,12 @@
white-space: nowrap;
}
-.data-grid th.corner {
+.data-grid th.corner,
+.data-grid td.corner {
width: 14px;
padding-right: 0px;
padding-left: 0px;
- border-right: 0 none transparent;
+ border-right: 0 none transparent !important;
}
.data-grid tr.filler {
@@ -69,7 +69,7 @@
position: absolute;
left: 0;
top: 0;
- right: 16px;
+ right: 0;
bottom: 0;
height: 100%;
border-top: 0 none transparent;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
