Title: [139515] trunk/Source/WebKit2
- Revision
- 139515
- Author
- a...@apple.com
- Date
- 2013-01-11 16:04:23 -0800 (Fri, 11 Jan 2013)
Log Message
[WK2] Make it possible to send sync messages from secondary threads
https://bugs.webkit.org/show_bug.cgi?id=106708
Apply another review comment (overlooked a "ditto").
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (139514 => 139515)
--- trunk/Source/WebKit2/ChangeLog 2013-01-12 00:01:56 UTC (rev 139514)
+++ trunk/Source/WebKit2/ChangeLog 2013-01-12 00:04:23 UTC (rev 139515)
@@ -3,6 +3,16 @@
[WK2] Make it possible to send sync messages from secondary threads
https://bugs.webkit.org/show_bug.cgi?id=106708
+ Apply another review comment (overlooked a "ditto").
+
+ * Platform/CoreIPC/Connection.cpp:
+ (CoreIPC::Connection::sendSyncMessage):
+
+2013-01-11 Alexey Proskuryakov <a...@apple.com>
+
+ [WK2] Make it possible to send sync messages from secondary threads
+ https://bugs.webkit.org/show_bug.cgi?id=106708
+
Reviewed by Anders Carlsson.
It is hugely beneficial to implement sync messages at Connection level, because
Modified: trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp (139514 => 139515)
--- trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp 2013-01-12 00:01:56 UTC (rev 139514)
+++ trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp 2013-01-12 00:04:23 UTC (rev 139515)
@@ -405,10 +405,8 @@
return sendSyncMessageFromSecondaryThread(messageID, syncRequestID, encoder, timeout);
}
- if (!isValid()) {
- didFailToSendSyncMessage();
+ if (!isValid())
return nullptr;
- }
// Push the pending sync reply information on our stack.
{
@@ -436,8 +434,6 @@
m_pendingSyncReplies.removeLast();
}
- // FIXME: Should we call didFailToSendSyncMessage()? It may be unexpected to get in on a background thread.
-
return reply.release();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
