Title: [139522] trunk/Tools
- Revision
- 139522
- Author
- jpar...@chromium.org
- Date
- 2013-01-11 16:41:48 -0800 (Fri, 11 Jan 2013)
Log Message
Builder should not be a valid parameter for stats dashboard
https://bugs.webkit.org/show_bug.cgi?id=106698
Reviewed by Dirk Pranke.
Since builder is a dashboard specific parameter, dashboard_base
should not be handling it in handleValidHashParameterWrapper, rather,
each specific dashboard should in its handleValidHashParameter function.
Note that the FIXME in dashboard_base about this was actually wrong -
we don't want to move it to g_crossDashboardState, because it isn't
actually cross dashboard state.
In fact, flakiness and treemap have the code in
handleValidHashParameter, but it is currently dead code because
dashboard_base gets to it first.
Added the proper handling to timeline_explorer, since builder is
valid there.
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/timeline_explorer.html:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139521 => 139522)
--- trunk/Tools/ChangeLog 2013-01-12 00:30:40 UTC (rev 139521)
+++ trunk/Tools/ChangeLog 2013-01-12 00:41:48 UTC (rev 139522)
@@ -1,3 +1,28 @@
+2013-01-11 Julie Parent <jpar...@chromium.org>
+
+ Builder should not be a valid parameter for stats dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=106698
+
+ Reviewed by Dirk Pranke.
+
+ Since builder is a dashboard specific parameter, dashboard_base
+ should not be handling it in handleValidHashParameterWrapper, rather,
+ each specific dashboard should in its handleValidHashParameter function.
+
+ Note that the FIXME in dashboard_base about this was actually wrong -
+ we don't want to move it to g_crossDashboardState, because it isn't
+ actually cross dashboard state.
+
+ In fact, flakiness and treemap have the code in
+ handleValidHashParameter, but it is currently dead code because
+ dashboard_base gets to it first.
+
+ Added the proper handling to timeline_explorer, since builder is
+ valid there.
+
+ * TestResultServer/static-dashboards/dashboard_base.js:
+ * TestResultServer/static-dashboards/timeline_explorer.html:
+
2013-01-11 Ryosuke Niwa <rn...@webkit.org>
REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (139521 => 139522)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-01-12 00:30:40 UTC (rev 139521)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-01-12 00:41:48 UTC (rev 139522)
@@ -185,12 +185,6 @@
});
return true;
- // FIXME: This should probably be stored on g_crossDashboardState like everything else in this function.
- case 'builder':
- validateParameter(g_currentState, key, value,
- function() { return value in currentBuilders(); });
- return true;
-
case 'useTestData':
case 'showAllRuns':
g_crossDashboardState[key] = value == 'true';
Modified: trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.html (139521 => 139522)
--- trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.html 2013-01-12 00:30:40 UTC (rev 139521)
+++ trunk/Tools/TestResultServer/static-dashboards/timeline_explorer.html 2013-01-12 00:41:48 UTC (rev 139522)
@@ -152,6 +152,10 @@
function handleValidHashParameter(key, value)
{
switch(key) {
+ case 'builder':
+ validateParameter(g_currentState, key, value,
+ function() { return value in currentBuilders(); });
+ return true;
case 'buildTimestamp':
g_currentState.buildTimestamp = parseInt(value, 10);
return true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
