Title: [139530] trunk/Source/WebKit/blackberry
- Revision
- 139530
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-11 17:49:56 -0800 (Fri, 11 Jan 2013)
Log Message
[BlackBerry] Focus zoom animation doesn't occur on devices with physical keyboard
https://bugs.webkit.org/show_bug.cgi?id=106719
Patch by Andrew Lo <a...@rim.com> on 2013-01-11
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.
Internal PR 278687
Always ensureFocusTextElementVisible if an element is focused when
the device has a physical keyboard.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementFocused):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (139529 => 139530)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-01-12 01:48:51 UTC (rev 139529)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-01-12 01:49:56 UTC (rev 139530)
@@ -1,3 +1,19 @@
+2013-01-11 Andrew Lo <a...@rim.com>
+
+ [BlackBerry] Focus zoom animation doesn't occur on devices with physical keyboard
+ https://bugs.webkit.org/show_bug.cgi?id=106719
+
+ Reviewed by Yong Li.
+ Internally reviewed by Mike Fenton.
+
+ Internal PR 278687
+
+ Always ensureFocusTextElementVisible if an element is focused when
+ the device has a physical keyboard.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::setElementFocused):
+
2013-01-11 Otto Derek Cheung <otche...@rim.com>
[BlackBerry] Modifying the databaseQuota call to WebPageClient
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (139529 => 139530)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-01-12 01:48:51 UTC (rev 139529)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-01-12 01:49:56 UTC (rev 139530)
@@ -64,6 +64,7 @@
#include "htmlediting.h"
#include "visible_units.h"
+#include <BlackBerryPlatformDeviceInfo.h>
#include <BlackBerryPlatformIMF.h>
#include <BlackBerryPlatformKeyboardEvent.h>
#include <BlackBerryPlatformLog.h>
@@ -900,7 +901,8 @@
frame->selection()->setFocused(isInputModeEnabled());
// Ensure visible when refocusing.
- m_shouldEnsureFocusTextElementVisibleOnSelectionChanged = isActiveTextEdit();
+ // If device does not have physical keyboard, wait to ensure visible until VKB resizes viewport so that both animations are combined into one.
+ m_shouldEnsureFocusTextElementVisibleOnSelectionChanged = isActiveTextEdit() || DeviceInfo::instance()->hasPhysicalKeyboard();
// Clear the existing focus node details.
setElementUnfocused(true /*refocusOccuring*/);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
