Diff
Modified: trunk/Source/WebCore/ChangeLog (139600 => 139601)
--- trunk/Source/WebCore/ChangeLog 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/ChangeLog 2013-01-14 11:10:36 UTC (rev 139601)
@@ -1,5 +1,42 @@
2013-01-14 Kentaro Hara <[email protected]>
+ [V8] Pass an Isolate to associateObjectWithWrapper()
+ https://bugs.webkit.org/show_bug.cgi?id=106773
+
+ Reviewed by Adam Barth.
+
+ In preparation for making an Isolate parameter mandatory
+ in associateObjectWithWrapper(), this patch passes an
+ Isolate to associateObjectWithWrapper().
+
+ No tests. No change in behavior.
+
+ * bindings/v8/custom/V8ArrayBufferCustom.cpp:
+ (WebCore::V8ArrayBuffer::constructorCallbackCustom):
+ * bindings/v8/custom/V8ArrayBufferViewCustom.h:
+ (WebCore::wrapArrayBufferView):
+ (WebCore::constructWebGLArray):
+ * bindings/v8/custom/V8AudioContextCustom.cpp:
+ (WebCore::V8AudioContext::constructorCallbackCustom):
+ * bindings/v8/custom/V8DOMFormDataCustom.cpp:
+ (WebCore::V8DOMFormData::constructorCallbackCustom):
+ * bindings/v8/custom/V8DataViewCustom.cpp:
+ (WebCore::V8DataView::constructorCallbackCustom):
+ * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
+ (WebCore::v8HTMLImageElementConstructorCallback):
+ * bindings/v8/custom/V8IntentCustom.cpp:
+ (WebCore::V8Intent::constructorCallbackCustom):
+ * bindings/v8/custom/V8MessageChannelCustom.cpp:
+ (WebCore::V8MessageChannel::constructorCallbackCustom):
+ * bindings/v8/custom/V8MutationObserverCustom.cpp:
+ (WebCore::V8MutationObserver::constructorCallbackCustom):
+ * bindings/v8/custom/V8WebKitPointCustom.cpp:
+ (WebCore::V8WebKitPoint::constructorCallbackCustom):
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+ (WebCore::V8XMLHttpRequest::constructorCallbackCustom):
+
+2013-01-14 Kentaro Hara <[email protected]>
+
[V8] Call Isolate::GetCurrent() in a callback from WebCore
https://bugs.webkit.org/show_bug.cgi?id=106766
Modified: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -76,7 +76,7 @@
v8::V8::AdjustAmountOfExternalAllocatedMemory(buffer->byteLength());
// Transform the holder into a wrapper object for the array.
v8::Handle<v8::Object> wrapper = args.Holder();
- V8DOMWrapper::associateObjectWithWrapper(buffer.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(buffer.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h 2013-01-14 11:10:36 UTC (rev 139601)
@@ -55,7 +55,7 @@
if (hasIndexer)
args.Holder()->SetIndexedPropertiesToExternalArrayData(array.get()->baseAddress(), arrayType, array.get()->length());
v8::Handle<v8::Object> wrapper = args.Holder();
- v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::associateObjectWithWrapper(array.release(), type, wrapper);
+ v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::associateObjectWithWrapper(array.release(), type, wrapper, args.GetIsolate());
wrapperHandle.MarkIndependent();
return wrapper;
}
@@ -225,7 +225,7 @@
}
v8::Handle<v8::Object> wrapper = args.Holder();
- v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::associateObjectWithWrapper(array.release(), type, wrapper);
+ v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::associateObjectWithWrapper(array.release(), type, wrapper, args.GetIsolate());
wrapperHandle.MarkIndependent();
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8AudioContextCustom.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8AudioContextCustom.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8AudioContextCustom.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -73,7 +73,7 @@
// Transform the holder into a wrapper object for the audio context.
v8::Handle<v8::Object> wrapper = args.Holder();
- V8DOMWrapper::associateObjectWithWrapper(audioContext.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(audioContext.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -47,7 +47,7 @@
RefPtr<DOMFormData> domFormData = DOMFormData::create(form);
v8::Handle<v8::Object> wrapper = args.Holder();
- V8DOMWrapper::associateObjectWithWrapper(domFormData.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(domFormData.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -39,7 +39,7 @@
// 'new DataView()' and the call used to construct the cached DataView object.
RefPtr<DataView> dataView = DataView::create(0);
v8::Handle<v8::Object> wrapper = args.Holder();
- V8DOMWrapper::associateObjectWithWrapper(dataView.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(dataView.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
if (args[0]->IsNull() || !V8ArrayBuffer::HasInstance(args[0]))
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -77,7 +77,7 @@
RefPtr<HTMLImageElement> image = HTMLImageElement::createForJSConstructor(document, optionalWidth, optionalHeight);
v8::Handle<v8::Object> wrapper = args.Holder();
- V8DOMWrapper::associateObjectWithWrapper(image.release(), &V8HTMLImageElementConstructor::info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(image.release(), &V8HTMLImageElementConstructor::info, wrapper, args.GetIsolate());
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -55,7 +55,7 @@
return setDOMException(ec, args.GetIsolate());
v8::Handle<v8::Object> wrapper = args.Holder();
- V8DOMWrapper::associateObjectWithWrapper(impl.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(impl.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
@@ -78,7 +78,7 @@
return setDOMException(ec, args.GetIsolate());
v8::Handle<v8::Object> wrapper = args.Holder();
- V8DOMWrapper::associateObjectWithWrapper(impl.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(impl.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -57,7 +57,7 @@
V8DOMWrapper::setNamedHiddenReference(wrapper, "port1", toV8(obj->port1(), args.Holder(), args.GetIsolate()));
V8DOMWrapper::setNamedHiddenReference(wrapper, "port2", toV8(obj->port2(), args.Holder(), args.GetIsolate()));
- V8DOMWrapper::associateObjectWithWrapper(obj.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(obj.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8MutationObserverCustom.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8MutationObserverCustom.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MutationObserverCustom.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -56,7 +56,7 @@
RefPtr<MutationCallback> callback = V8MutationCallback::create(arg, context, wrapper);
RefPtr<MutationObserver> observer = MutationObserver::create(callback.release());
- V8DOMWrapper::associateObjectWithWrapper(observer.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(observer.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -57,7 +57,7 @@
}
RefPtr<WebKitPoint> point = WebKitPoint::create(x, y);
v8::Handle<v8::Object> wrapper = args.Holder();
- V8DOMWrapper::associateObjectWithWrapper(point.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(point.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp (139600 => 139601)
--- trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp 2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp 2013-01-14 11:10:36 UTC (rev 139601)
@@ -61,7 +61,7 @@
RefPtr<XMLHttpRequest> xmlHttpRequest = XMLHttpRequest::create(context, securityOrigin);
v8::Handle<v8::Object> wrapper = args.Holder();
- V8DOMWrapper::associateObjectWithWrapper(xmlHttpRequest.release(), &info, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(xmlHttpRequest.release(), &info, wrapper, args.GetIsolate());
return wrapper;
}
