Title: [139830] trunk/Tools
- Revision
- 139830
- Author
- [email protected]
- Date
- 2013-01-15 20:42:47 -0800 (Tue, 15 Jan 2013)
Log Message
remove extraneous output in test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=106971
Reviewed by Ojan Vafai.
We weren't ignoring or capturing the echoed output from
these two tests, and getting noise in the logs as a result.
* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_auto_stringify_args):
(ExecutiveTest.test_popen_args):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (139829 => 139830)
--- trunk/Tools/ChangeLog 2013-01-16 04:36:33 UTC (rev 139829)
+++ trunk/Tools/ChangeLog 2013-01-16 04:42:47 UTC (rev 139830)
@@ -1,5 +1,19 @@
2013-01-15 Dirk Pranke <[email protected]>
+ remove extraneous output in test-webkitpy
+ https://bugs.webkit.org/show_bug.cgi?id=106971
+
+ Reviewed by Ojan Vafai.
+
+ We weren't ignoring or capturing the echoed output from
+ these two tests, and getting noise in the logs as a result.
+
+ * Scripts/webkitpy/common/system/executive_unittest.py:
+ (ExecutiveTest.test_auto_stringify_args):
+ (ExecutiveTest.test_popen_args):
+
+2013-01-15 Dirk Pranke <[email protected]>
+
webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
https://bugs.webkit.org/show_bug.cgi?id=106974
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py (139829 => 139830)
--- trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2013-01-16 04:36:33 UTC (rev 139829)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2013-01-16 04:42:47 UTC (rev 139830)
@@ -116,13 +116,13 @@
def test_auto_stringify_args(self):
executive = Executive()
executive.run_command(command_line('echo', 1))
- executive.popen(command_line('echo', 1)).wait()
+ executive.popen(command_line('echo', 1), stdout=executive.PIPE).wait()
self.assertEqual('echo 1', executive.command_for_printing(['echo', 1]))
def test_popen_args(self):
executive = Executive()
# Explicitly naming the 'args' argument should not thow an exception.
- executive.popen(args=command_line('echo', 1)).wait()
+ executive.popen(args=command_line('echo', 1), stdout=executive.PIPE).wait()
def test_run_command_with_unicode(self):
"""Validate that it is safe to pass unicode() objects
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
