Title: [139868] trunk/Tools
Revision
139868
Author
ser...@webkit.org
Date
2013-01-16 04:00:50 -0800 (Wed, 16 Jan 2013)

Log Message

[GTK] build-webkit fails if the jhbuild wrapper is not used
https://bugs.webkit.org/show_bug.cgi?id=106769

Reviewed by Martin Robinson.

Return an empty array instead of "" in
jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
will not be recognized as a valid command when the returned array
is directly passed to perl's system() call.

* Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (139867 => 139868)


--- trunk/Tools/ChangeLog	2013-01-16 11:51:32 UTC (rev 139867)
+++ trunk/Tools/ChangeLog	2013-01-16 12:00:50 UTC (rev 139868)
@@ -1,3 +1,18 @@
+2013-01-16  Sergio Villar Senin  <svil...@igalia.com>
+
+        [GTK] build-webkit fails if the jhbuild wrapper is not used
+        https://bugs.webkit.org/show_bug.cgi?id=106769
+
+        Reviewed by Martin Robinson.
+
+        Return an empty array instead of "" in
+        jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
+        will not be recognized as a valid command when the returned array
+        is directly passed to perl's system() call.
+
+        * Scripts/webkitdirs.pm:
+        (jhbuildWrapperPrefixIfNeeded):
+
 2013-01-16  Jochen Eisinger  <joc...@chromium.org>
 
         [chromium] add title text direction attribute to TestRunner

Modified: trunk/Tools/Scripts/webkitdirs.pm (139867 => 139868)


--- trunk/Tools/Scripts/webkitdirs.pm	2013-01-16 11:51:32 UTC (rev 139867)
+++ trunk/Tools/Scripts/webkitdirs.pm	2013-01-16 12:00:50 UTC (rev 139868)
@@ -2130,7 +2130,7 @@
         return @prefix;
     }
 
-    return "";
+    return ();
 }
 
 sub removeCMakeCache()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to