Title: [139996] trunk/Source/WebCore
- Revision
- 139996
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-17 10:44:12 -0800 (Thu, 17 Jan 2013)
Log Message
Web Inspector: [Timeline] REGRESSION: Sidebar shrinks when user switches to memory statistics mode.
https://bugs.webkit.org/show_bug.cgi?id=105857
Patch by Eugene Klyuchnikov <eus...@chromium.org> on 2013-01-17
Reviewed by Pavel Feldman.
Fix: do not apply constraints to sidebar width while view is offscreen;
constraint check will be applied when view goes visible.
* inspector/front-end/SidebarView.js:
(WebInspector.SidebarView.prototype.applyConstraints): Check if view is
offscreen.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139995 => 139996)
--- trunk/Source/WebCore/ChangeLog 2013-01-17 18:43:49 UTC (rev 139995)
+++ trunk/Source/WebCore/ChangeLog 2013-01-17 18:44:12 UTC (rev 139996)
@@ -1,3 +1,17 @@
+2013-01-17 Eugene Klyuchnikov <eus...@chromium.org>
+
+ Web Inspector: [Timeline] REGRESSION: Sidebar shrinks when user switches to memory statistics mode.
+ https://bugs.webkit.org/show_bug.cgi?id=105857
+
+ Reviewed by Pavel Feldman.
+
+ Fix: do not apply constraints to sidebar width while view is offscreen;
+ constraint check will be applied when view goes visible.
+
+ * inspector/front-end/SidebarView.js:
+ (WebInspector.SidebarView.prototype.applyConstraints): Check if view is
+ offscreen.
+
2013-01-17 Alexander Pavlov <apav...@chromium.org>
Web Inspector: [Spectrum] Color picker in CSS editor does not update textual color value
Modified: trunk/Source/WebCore/inspector/front-end/SidebarView.js (139995 => 139996)
--- trunk/Source/WebCore/inspector/front-end/SidebarView.js 2013-01-17 18:43:49 UTC (rev 139995)
+++ trunk/Source/WebCore/inspector/front-end/SidebarView.js 2013-01-17 18:44:12 UTC (rev 139996)
@@ -146,7 +146,8 @@
*/
applyConstraints: function(size)
{
- return Number.constrain(size, this._minimumSidebarWidth, this.element.offsetWidth * (100 - this._minimumMainWidthPercent) / 100);
+ var offsetWidth = this.element.offsetWidth;
+ return offsetWidth ? Number.constrain(size, this._minimumSidebarWidth, offsetWidth * (100 - this._minimumMainWidthPercent) / 100) : size;
},
hideMainElement: function()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
