Title: [140015] trunk/Source/WebCore
- Revision
- 140015
- Author
- yu...@chromium.org
- Date
- 2013-01-17 11:42:17 -0800 (Thu, 17 Jan 2013)
Log Message
Web Inspector: InstrumentingAgents should be registered in InspectorInstrumentation only when there is a front-end
https://bugs.webkit.org/show_bug.cgi?id=107127
Reviewed by Vsevolod Vlasov.
InspectorInstrumentation::registerInstrumentingAgents is called when front-end
is connected to corresponding InspectorController. When the front-end disconnects
InspectorInstrumentation::unregisterInstrumentingAgents is called.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140014 => 140015)
--- trunk/Source/WebCore/ChangeLog 2013-01-17 19:35:41 UTC (rev 140014)
+++ trunk/Source/WebCore/ChangeLog 2013-01-17 19:42:17 UTC (rev 140015)
@@ -1,3 +1,20 @@
+2013-01-17 Yury Semikhatsky <yu...@chromium.org>
+
+ Web Inspector: InstrumentingAgents should be registered in InspectorInstrumentation only when there is a front-end
+ https://bugs.webkit.org/show_bug.cgi?id=107127
+
+ Reviewed by Vsevolod Vlasov.
+
+ InspectorInstrumentation::registerInstrumentingAgents is called when front-end
+ is connected to corresponding InspectorController. When the front-end disconnects
+ InspectorInstrumentation::unregisterInstrumentingAgents is called.
+
+ * inspector/InspectorController.cpp:
+ (WebCore::InspectorController::InspectorController):
+ (WebCore::InspectorController::inspectedPageDestroyed):
+ (WebCore::InspectorController::connectFrontend):
+ (WebCore::InspectorController::disconnectFrontend):
+
2013-01-17 Andrei Bucur <abu...@adobe.com>
[CSS Regions] Content flows incorrectly in autoheight regions with min/max-height set
Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (140014 => 140015)
--- trunk/Source/WebCore/inspector/InspectorController.cpp 2013-01-17 19:35:41 UTC (rev 140014)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2013-01-17 19:42:17 UTC (rev 140015)
@@ -175,8 +175,6 @@
#if ENABLE(_javascript__DEBUGGER)
runtimeAgent->setScriptDebugServer(&m_debuggerAgent->scriptDebugServer());
#endif
-
- InspectorInstrumentation::registerInstrumentingAgents(m_instrumentingAgents.get());
}
InspectorController::~InspectorController()
@@ -193,7 +191,6 @@
void InspectorController::inspectedPageDestroyed()
{
disconnectFrontend();
- InspectorInstrumentation::unregisterInstrumentingAgents(m_instrumentingAgents.get());
m_injectedScriptManager->disconnect();
m_inspectorClient->inspectorDestroyed();
m_inspectorClient = 0;
@@ -231,6 +228,7 @@
m_agents.setFrontend(m_inspectorFrontend.get());
+ InspectorInstrumentation::registerInstrumentingAgents(m_instrumentingAgents.get());
InspectorInstrumentation::frontendCreated();
ASSERT(m_inspectorClient);
@@ -257,6 +255,7 @@
// relese overlay page resources
m_overlay->freePage();
InspectorInstrumentation::frontendDeleted();
+ InspectorInstrumentation::unregisterInstrumentingAgents(m_instrumentingAgents.get());
}
void InspectorController::show()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
