Title: [140063] trunk/Source/WebCore
- Revision
- 140063
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-17 16:04:37 -0800 (Thu, 17 Jan 2013)
Log Message
[TexMap] Match initializing members in GraphicsLayerTransform to initializing members in GraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=107090
Patch by Huang Dongsung <luxte...@company100.net> on 2013-01-17
Reviewed by Noam Rosenthal.
GraphicsLayer initializes m_anchorPoint to FloatPoint3D(0.5, 0.5, 0) and
m_preserves3D to false, while GraphicsLayerTransform initializes m_anchorPoint
to FloatPoint3D(0, 0, 0) and m_flattening (= !m_preserves3D) to false. It is a
potential bug. This patch corrects initialization of GraphicsLayerTransform.
Covered by existing compositing pixel tests.
* platform/graphics/GraphicsLayerTransform.cpp:
(WebCore::GraphicsLayerTransform::GraphicsLayerTransform):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140062 => 140063)
--- trunk/Source/WebCore/ChangeLog 2013-01-17 23:52:40 UTC (rev 140062)
+++ trunk/Source/WebCore/ChangeLog 2013-01-18 00:04:37 UTC (rev 140063)
@@ -1,3 +1,20 @@
+2013-01-17 Huang Dongsung <luxte...@company100.net>
+
+ [TexMap] Match initializing members in GraphicsLayerTransform to initializing members in GraphicsLayer.
+ https://bugs.webkit.org/show_bug.cgi?id=107090
+
+ Reviewed by Noam Rosenthal.
+
+ GraphicsLayer initializes m_anchorPoint to FloatPoint3D(0.5, 0.5, 0) and
+ m_preserves3D to false, while GraphicsLayerTransform initializes m_anchorPoint
+ to FloatPoint3D(0, 0, 0) and m_flattening (= !m_preserves3D) to false. It is a
+ potential bug. This patch corrects initialization of GraphicsLayerTransform.
+
+ Covered by existing compositing pixel tests.
+
+ * platform/graphics/GraphicsLayerTransform.cpp:
+ (WebCore::GraphicsLayerTransform::GraphicsLayerTransform):
+
2013-01-17 Filip Pizlo <fpi...@apple.com>
ScriptDebugServer::didExecuteProgram should not try to pop stack if there is no stack to pop
Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayerTransform.cpp (140062 => 140063)
--- trunk/Source/WebCore/platform/graphics/GraphicsLayerTransform.cpp 2013-01-17 23:52:40 UTC (rev 140062)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayerTransform.cpp 2013-01-18 00:04:37 UTC (rev 140063)
@@ -23,7 +23,8 @@
namespace WebCore {
GraphicsLayerTransform::GraphicsLayerTransform()
- : m_flattening(false)
+ : m_anchorPoint(0.5, 0.5, 0)
+ , m_flattening(true)
, m_dirty(false) // false by default since all default values would be combined as the identity matrix
, m_childrenDirty(false)
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
