Title: [140067] trunk/Tools
- Revision
- 140067
- Author
- simon.fra...@apple.com
- Date
- 2013-01-17 16:10:40 -0800 (Thu, 17 Jan 2013)
Log Message
Ref test images are upside-down in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=105457
Reviewed by Sam "Speedy" Weinig.
The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
from the window snapshot contained a flipped copy of the image, causing all ref
and pixel images to be upside-down.
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (140066 => 140067)
--- trunk/Tools/ChangeLog 2013-01-18 00:10:31 UTC (rev 140066)
+++ trunk/Tools/ChangeLog 2013-01-18 00:10:40 UTC (rev 140067)
@@ -1,3 +1,17 @@
+2013-01-17 Simon Fraser <simon.fra...@apple.com>
+
+ Ref test images are upside-down in WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=105457
+
+ Reviewed by Sam "Speedy" Weinig.
+
+ The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
+ from the window snapshot contained a flipped copy of the image, causing all ref
+ and pixel images to be upside-down.
+
+ * WebKitTestRunner/cg/TestInvocationCG.cpp:
+ (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
+
2013-01-17 Timothy Loh <tim...@google.com>
Replaced specifiers variable with is_debug in builders.py
Modified: trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp (140066 => 140067)
--- trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp 2013-01-18 00:10:31 UTC (rev 140066)
+++ trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp 2013-01-18 00:10:40 UTC (rev 140067)
@@ -165,7 +165,7 @@
RetainPtr<CGContextRef> context;
if (windowSnapshot)
- context.adoptCF(createCGContextFromImage(windowSnapshot.get(), FlipGraphicsContext));
+ context.adoptCF(createCGContextFromImage(windowSnapshot.get(), DontFlipGraphicsContext));
else
context.adoptCF(createCGContextFromImage(image));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
