Title: [140073] trunk/Source/WebCore
Revision
140073
Author
simon.fra...@apple.com
Date
2013-01-17 17:07:13 -0800 (Thu, 17 Jan 2013)

Log Message

Fix crash accessing RenderView's layer's backing when not composited
https://bugs.webkit.org/show_bug.cgi?id=107203

Reviewed by Benjamin Poulain.

The RenderView isn't always layer-backed in WebKit1, so null-check the backing.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (140072 => 140073)


--- trunk/Source/WebCore/ChangeLog	2013-01-18 00:41:02 UTC (rev 140072)
+++ trunk/Source/WebCore/ChangeLog	2013-01-18 01:07:13 UTC (rev 140073)
@@ -1,3 +1,15 @@
+2013-01-17  Simon Fraser  <simon.fra...@apple.com>
+
+        Fix crash accessing RenderView's layer's backing when not composited
+        https://bugs.webkit.org/show_bug.cgi?id=107203
+
+        Reviewed by Benjamin Poulain.
+
+        The RenderView isn't always layer-backed in WebKit1, so null-check the backing.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged):
+
 2013-01-16  Ryosuke Niwa  <rn...@webkit.org>
 
         Remove NodeListsNodeData when it's no longer needed

Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (140072 => 140073)


--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2013-01-18 00:41:02 UTC (rev 140072)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2013-01-18 01:07:13 UTC (rev 140073)
@@ -1206,7 +1206,7 @@
 void RenderLayerCompositor::rootFixedBackgroundsChanged()
 {
     RenderLayerBacking* renderViewBacking = m_renderView->layer()->backing();
-    if (renderViewBacking->usingTileCache())
+    if (renderViewBacking && renderViewBacking->usingTileCache())
         setCompositingLayersNeedRebuild();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to