Title: [140288] trunk/Source/WebCore
Revision
140288
Author
[email protected]
Date
2013-01-20 18:29:56 -0800 (Sun, 20 Jan 2013)

Log Message

Unreviewed, rolling out r140270.
http://trac.webkit.org/changeset/140270
https://bugs.webkit.org/show_bug.cgi?id=107253

Hit asserts in a debug build

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (140287 => 140288)


--- trunk/Source/WebCore/ChangeLog	2013-01-21 02:24:47 UTC (rev 140287)
+++ trunk/Source/WebCore/ChangeLog	2013-01-21 02:29:56 UTC (rev 140288)
@@ -1,3 +1,14 @@
+2013-01-20  Kentaro Hara  <[email protected]>
+
+        Unreviewed, rolling out r140270.
+        http://trac.webkit.org/changeset/140270
+        https://bugs.webkit.org/show_bug.cgi?id=107253
+
+        Hit asserts in a debug build
+
+        * bindings/v8/V8DOMWindowShell.cpp:
+        (WebCore::V8DOMWindowShell::installDOMWindow):
+
 2013-01-20  Shinya Kawanaka  <[email protected]>
 
         [Shadow DOM] Specifying scrollbar style of an element having RenderLayer in ShadowDOM does not work.

Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (140287 => 140288)


--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2013-01-21 02:24:47 UTC (rev 140287)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2013-01-21 02:29:56 UTC (rev 140288)
@@ -317,7 +317,7 @@
 
     V8DOMWindow::installPerContextProperties(windowWrapper, window);
 
-    V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, v8::Handle<v8::Object>::Cast(windowWrapper->GetPrototype()), m_isolate);
+    V8DOMWrapper::setNativeInfo(v8::Handle<v8::Object>::Cast(windowWrapper->GetPrototype()), &V8DOMWindow::info, window);
 
     // Install the windowWrapper as the prototype of the innerGlobalObject.
     // The full structure of the global object is as follows:
@@ -333,7 +333,7 @@
     //       _javascript_ object.
     //
     v8::Handle<v8::Object> innerGlobalObject = toInnerGlobalObject(m_context.get());
-    V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, innerGlobalObject, m_isolate);
+    V8DOMWrapper::setNativeInfo(innerGlobalObject, &V8DOMWindow::info, window);
     innerGlobalObject->SetPrototype(windowWrapper);
     V8DOMWrapper::associateObjectWithWrapper(PassRefPtr<DOMWindow>(window), &V8DOMWindow::info, windowWrapper, m_isolate);
     return true;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to