Title: [140293] trunk
- Revision
- 140293
- Author
- [email protected]
- Date
- 2013-01-20 21:23:41 -0800 (Sun, 20 Jan 2013)
Log Message
Unreviewed, rolling out r140290.
http://trac.webkit.org/changeset/140290
https://bugs.webkit.org/show_bug.cgi?id=107412
Broke tests of inspector and calendar picker in debug build
(Requested by tkent on #webkit).
Patch by Sheriff Bot <[email protected]> on 2013-01-20
Source/WebCore:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
LayoutTests:
* fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt: Removed.
* fast/css/box-sizing-border-box-dynamic-padding-border-update.html: Removed.
* fast/forms/text/text-padding-dynamic-change-expected.html: Removed.
* fast/forms/text/text-padding-dynamic-change.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (140292 => 140293)
--- trunk/LayoutTests/ChangeLog 2013-01-21 05:12:37 UTC (rev 140292)
+++ trunk/LayoutTests/ChangeLog 2013-01-21 05:23:41 UTC (rev 140293)
@@ -1,3 +1,17 @@
+2013-01-20 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r140290.
+ http://trac.webkit.org/changeset/140290
+ https://bugs.webkit.org/show_bug.cgi?id=107412
+
+ Broke tests of inspector and calendar picker in debug build
+ (Requested by tkent on #webkit).
+
+ * fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt: Removed.
+ * fast/css/box-sizing-border-box-dynamic-padding-border-update.html: Removed.
+ * fast/forms/text/text-padding-dynamic-change-expected.html: Removed.
+ * fast/forms/text/text-padding-dynamic-change.html: Removed.
+
2013-01-20 Yongsheng Zhu <[email protected]>
Dispatch LongPress to inner frames
Deleted: trunk/LayoutTests/fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt (140292 => 140293)
--- trunk/LayoutTests/fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt 2013-01-21 05:12:37 UTC (rev 140292)
+++ trunk/LayoutTests/fast/css/box-sizing-border-box-dynamic-padding-border-update-expected.txt 2013-01-21 05:23:41 UTC (rev 140293)
@@ -1,8 +0,0 @@
-Test if child blocks are correctly laid out when padding/border of the box-sizing:border-box parent is updated.
-
-The quick brown fox jumps over the lazy dog.
-PASS
-The quick brown fox jumps over the lazy dog.
-PASS
-The quick brown fox jumps over the lazy dog.
-PASS
Deleted: trunk/LayoutTests/fast/css/box-sizing-border-box-dynamic-padding-border-update.html (140292 => 140293)
--- trunk/LayoutTests/fast/css/box-sizing-border-box-dynamic-padding-border-update.html 2013-01-21 05:12:37 UTC (rev 140292)
+++ trunk/LayoutTests/fast/css/box-sizing-border-box-dynamic-padding-border-update.html 2013-01-21 05:23:41 UTC (rev 140293)
@@ -1,24 +0,0 @@
-<!DOCTYPE html>
-<body>
-<p>Test if child blocks are correctly laid out when padding/border of the box-sizing:border-box parent is updated.</p>
-
-<div id="target1" style="width:100px; box-sizing:border-box; border:0 solid;">
-<div data-expected-width="50">The quick brown fox jumps over the lazy dog.</div>
-</div>
-<div id="target2" style="width:100px; box-sizing:border-box;">
-<div data-expected-width="50">The quick brown fox jumps over the lazy dog.</div>
-</div>
-<div id="target3" style="width:100px; box-sizing:border-box;">
-<div data-expected-width="50">The quick brown fox jumps over the lazy dog.</div>
-</div>
-<script src=""
-<script>
-document.body.offsetLeft;
-document.getElementById('target1').style.borderLeftWidth = '50px';
-document.getElementById('target2').style.paddingLeft = '50px';
-document.getElementById('target3').setAttribute('style', 'width:50px; box-sizing:content-box; border-left:50px solid;');
-checkLayout('#target1');
-checkLayout('#target2');
-checkLayout('#target3');
-</script>
-</body>
Deleted: trunk/LayoutTests/fast/forms/text/text-padding-dynamic-change-expected.html (140292 => 140293)
--- trunk/LayoutTests/fast/forms/text/text-padding-dynamic-change-expected.html 2013-01-21 05:12:37 UTC (rev 140292)
+++ trunk/LayoutTests/fast/forms/text/text-padding-dynamic-change-expected.html 2013-01-21 05:23:41 UTC (rev 140293)
@@ -1,7 +0,0 @@
-<!DOCTYPE html>
-<body>
-<input style="box-sizing:border-box; width:100px; text-align:right; padding-left:40px;" value="Hello world">
-<input style="box-sizing:border-box; width:100px; text-align:right; padding-left:40px;" placeholder="Hello world">
-<input style="box-sizing:border-box; width:100px; text-align:right; border-left-width:40px;" value="Hello world">
-<input style="box-sizing:border-box; width:100px; text-align:right; border-left-width:40px;" placeholder="Hello world">
-</body>
Deleted: trunk/LayoutTests/fast/forms/text/text-padding-dynamic-change.html (140292 => 140293)
--- trunk/LayoutTests/fast/forms/text/text-padding-dynamic-change.html 2013-01-21 05:12:37 UTC (rev 140292)
+++ trunk/LayoutTests/fast/forms/text/text-padding-dynamic-change.html 2013-01-21 05:23:41 UTC (rev 140293)
@@ -1,14 +0,0 @@
-<!DOCTYPE html>
-<body>
-<input id=text1 style="box-sizing:border-box; width:100px; text-align:right;" value="Hello world">
-<input id=text2 style="box-sizing:border-box; width:100px; text-align:right;" placeholder="Hello world">
-<input id=text3 style="box-sizing:border-box; width:100px; text-align:right;" value="Hello world">
-<input id=text4 style="box-sizing:border-box; width:100px; text-align:right;" placeholder="Hello world">
-<script>
-document.body.offsetLeft;
-document.getElementById('text1').style.paddingLeft = '40px';
-document.getElementById('text2').style.paddingLeft = '40px';
-document.getElementById('text3').style.borderLeftWidth = '40px';
-document.getElementById('text4').style.borderLeftWidth = '40px';
-</script>
-</body>
Modified: trunk/Source/WebCore/ChangeLog (140292 => 140293)
--- trunk/Source/WebCore/ChangeLog 2013-01-21 05:12:37 UTC (rev 140292)
+++ trunk/Source/WebCore/ChangeLog 2013-01-21 05:23:41 UTC (rev 140293)
@@ -1,3 +1,15 @@
+2013-01-20 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r140290.
+ http://trac.webkit.org/changeset/140290
+ https://bugs.webkit.org/show_bug.cgi?id=107412
+
+ Broke tests of inspector and calendar picker in debug build
+ (Requested by tkent on #webkit).
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::styleDidChange):
+
2013-01-20 Yongsheng Zhu <[email protected]>
Dispatch LongPress to inner frames
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (140292 => 140293)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2013-01-21 05:12:37 UTC (rev 140292)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2013-01-21 05:23:41 UTC (rev 140293)
@@ -305,12 +305,6 @@
#if ENABLE(CSS_EXCLUSIONS)
updateExclusionShapeOutsideInfoAfterStyleChange(style()->shapeOutside(), oldStyle ? oldStyle->shapeOutside() : 0);
#endif
-
- if (oldStyle && (newStyle->boxSizing() == BORDER_BOX || oldStyle->boxSizing() == BORDER_BOX)
- && (newStyle->paddingBox() != oldStyle->paddingBox() || newStyle->border() != oldStyle->border())) {
- for (RenderBox* child = firstChildBox(); child; child = child->nextSiblingBox())
- child->setChildNeedsLayout(true, MarkOnlyThis);
- }
}
#if ENABLE(CSS_EXCLUSIONS)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo/webkit-changes
