Title: [140422] trunk/Source/WebCore
- Revision
- 140422
- Author
- christophe.du...@intel.com
- Date
- 2013-01-22 06:53:28 -0800 (Tue, 22 Jan 2013)
Log Message
Regression(r140414): It is causing crashes with gstreamer 0.10
https://bugs.webkit.org/show_bug.cgi?id=107554
Reviewed by Philippe Normand.
gstreamer 0.10 doc led me to believe that gst_element_factory_make()
was not returning a floating reference. However, based on testing
(and results on Qt port) it does so we should NOT adopt the
returned GstElement object.
No new tests, already covered by existing tests.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140421 => 140422)
--- trunk/Source/WebCore/ChangeLog 2013-01-22 14:43:38 UTC (rev 140421)
+++ trunk/Source/WebCore/ChangeLog 2013-01-22 14:53:28 UTC (rev 140422)
@@ -1,3 +1,19 @@
+2013-01-22 Christophe Dumez <christophe.du...@intel.com>
+
+ Regression(r140414): It is causing crashes with gstreamer 0.10
+ https://bugs.webkit.org/show_bug.cgi?id=107554
+
+ Reviewed by Philippe Normand.
+
+ gstreamer 0.10 doc led me to believe that gst_element_factory_make()
+ was not returning a floating reference. However, based on testing
+ (and results on Qt port) it does so we should NOT adopt the
+ returned GstElement object.
+
+ No new tests, already covered by existing tests.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+
2013-01-22 Andrey Lushnikov <lushni...@chromium.org>
Web Inspector: do not highlight really long lines in DTE.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (140421 => 140422)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2013-01-22 14:43:38 UTC (rev 140421)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2013-01-22 14:53:28 UTC (rev 140422)
@@ -1793,12 +1793,11 @@
{
ASSERT(!m_playBin);
-#ifdef GST_API_VERSION_1
- // In gstreamer 1.0, gst_element_factory_make returns a floating
- // reference so we should not adopt.
+ // gst_element_factory_make() returns a floating reference so
+ // we should not adopt.
m_playBin = gst_element_factory_make(gPlaybinName, "play");
-#else
- m_playBin = adoptGRef(gst_element_factory_make(gPlaybinName, "play"));
+
+#ifndef GST_API_VERSION_1
m_gstGWorld = GStreamerGWorld::createGWorld(m_playBin.get());
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
