Title: [140426] trunk/Source/WebCore
Revision
140426
Author
commit-qu...@webkit.org
Date
2013-01-22 08:07:21 -0800 (Tue, 22 Jan 2013)

Log Message

Web Inspector: [Network] "Secure" cookies can not be deleted.
https://bugs.webkit.org/show_bug.cgi?id=107543

Patch by Eugene Klyuchnikov <eus...@chromium.org> on 2013-01-22
Reviewed by Pavel Feldman.

To delete secure cookie URL schema need to be "https" instead of "http".

* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._deleteCookie):
Take care of secure cookies.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (140425 => 140426)


--- trunk/Source/WebCore/ChangeLog	2013-01-22 16:05:39 UTC (rev 140425)
+++ trunk/Source/WebCore/ChangeLog	2013-01-22 16:07:21 UTC (rev 140426)
@@ -1,3 +1,16 @@
+2013-01-22  Eugene Klyuchnikov  <eus...@chromium.org>
+
+        Web Inspector: [Network] "Secure" cookies can not be deleted.
+        https://bugs.webkit.org/show_bug.cgi?id=107543
+
+        Reviewed by Pavel Feldman.
+
+        To delete secure cookie URL schema need to be "https" instead of "http".
+
+        * inspector/front-end/CookieItemsView.js:
+        (WebInspector.CookieItemsView.prototype._deleteCookie):
+        Take care of secure cookies.
+
 2013-01-22  Sheriff Bot  <webkit.review....@gmail.com>
 
         Unreviewed, rolling out r140420.

Modified: trunk/Source/WebCore/inspector/front-end/CookieItemsView.js (140425 => 140426)


--- trunk/Source/WebCore/inspector/front-end/CookieItemsView.js	2013-01-22 16:05:39 UTC (rev 140425)
+++ trunk/Source/WebCore/inspector/front-end/CookieItemsView.js	2013-01-22 16:07:21 UTC (rev 140426)
@@ -143,7 +143,7 @@
      */
     _deleteCookie: function(cookie)
     {
-        PageAgent.deleteCookie(cookie.name(), "http://" + cookie.domain() + cookie.path());
+        PageAgent.deleteCookie(cookie.name(), (cookie.secure() ? "https://" : "http://") + cookie.domain() + cookie.path());
         this._update();
     },
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to