Title: [140628] trunk/Source/WebCore
- Revision
- 140628
- Author
- to...@chromium.org
- Date
- 2013-01-23 18:17:24 -0800 (Wed, 23 Jan 2013)
Log Message
Teach threaded HTML parser to update InspectorInstrumentation when writing HTML
https://bugs.webkit.org/show_bug.cgi?id=107755
Reviewed by Eric Seidel.
The current length is unused, so it doesn't cause any noticeable behavior difference to not pass it here.
No new tests because covered by existing tests.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processTokensFromBackgroundParser):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140627 => 140628)
--- trunk/Source/WebCore/ChangeLog 2013-01-24 02:16:20 UTC (rev 140627)
+++ trunk/Source/WebCore/ChangeLog 2013-01-24 02:17:24 UTC (rev 140628)
@@ -1,3 +1,17 @@
+2013-01-23 Tony Gentilcore <to...@chromium.org>
+
+ Teach threaded HTML parser to update InspectorInstrumentation when writing HTML
+ https://bugs.webkit.org/show_bug.cgi?id=107755
+
+ Reviewed by Eric Seidel.
+
+ The current length is unused, so it doesn't cause any noticeable behavior difference to not pass it here.
+
+ No new tests because covered by existing tests.
+
+ * html/parser/HTMLDocumentParser.cpp:
+ (WebCore::HTMLDocumentParser::processTokensFromBackgroundParser):
+
2013-01-23 Kentaro Hara <hara...@chromium.org>
[V8] Make an Isolate parameter mandatory in NativeToJS()
Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (140627 => 140628)
--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-01-24 02:16:20 UTC (rev 140627)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-01-24 02:17:24 UTC (rev 140628)
@@ -290,7 +290,8 @@
// but we need to ensure it isn't deleted yet.
RefPtr<HTMLDocumentParser> protect(this);
- // FIXME: Add support for InspectorInstrumentation.
+ // FIXME: Pass in current input length.
+ InspectorInstrumentationCookie cookie = InspectorInstrumentation::willWriteHTML(document(), 0, lineNumber().zeroBasedInt());
for (Vector<CompactHTMLToken>::const_iterator it = tokens->begin(); it != tokens->end(); ++it) {
ASSERT(!isWaitingForScripts());
@@ -300,7 +301,7 @@
constructTreeFromCompactHTMLToken(*it);
if (isStopped())
- return;
+ break;
// FIXME: We'll probably need to check document()->frame()->navigationScheduler()->locationChangePending())
// as we do in canTakeNextToken;
@@ -308,15 +309,17 @@
if (isWaitingForScripts()) {
ASSERT(it + 1 == tokens->end()); // The </script> is assumed to be the last token of this bunch.
runScriptsForPausedTreeBuilder();
- return;
+ break;
}
if (it->type() == HTMLTokenTypes::EndOfFile) {
ASSERT(it + 1 == tokens->end()); // The EOF is assumed to be the last token of this bunch.
prepareToStopParsing();
- return;
+ break;
}
}
+
+ InspectorInstrumentation::didWriteHTML(cookie, lineNumber().zeroBasedInt());
}
#endif // ENABLE(THREADED_HTML_PARSER)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
