Title: [140786] trunk/Tools
- Revision
- 140786
- Author
- aba...@webkit.org
- Date
- 2013-01-24 23:00:11 -0800 (Thu, 24 Jan 2013)
Log Message
HTTP 500 error between QueueStatusServer and bot(s)
https://bugs.webkit.org/show_bug.cgi?id=107184
Patch by Alan Cutter <alancut...@chromium.org> on 2013-01-24
Reviewed by Adam Barth.
Removed the use of memcache which was the source of the exception.
* QueueStatusServer/handlers/updatestatus.py:
(UpdateStatus.post):
* QueueStatusServer/model/attachment.py:
(Attachment):
(Attachment.summary):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (140785 => 140786)
--- trunk/Tools/ChangeLog 2013-01-25 06:57:41 UTC (rev 140785)
+++ trunk/Tools/ChangeLog 2013-01-25 07:00:11 UTC (rev 140786)
@@ -1,3 +1,18 @@
+2013-01-24 Alan Cutter <alancut...@chromium.org>
+
+ HTTP 500 error between QueueStatusServer and bot(s)
+ https://bugs.webkit.org/show_bug.cgi?id=107184
+
+ Reviewed by Adam Barth.
+
+ Removed the use of memcache which was the source of the exception.
+
+ * QueueStatusServer/handlers/updatestatus.py:
+ (UpdateStatus.post):
+ * QueueStatusServer/model/attachment.py:
+ (Attachment):
+ (Attachment.summary):
+
2013-01-24 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r140653.
Modified: trunk/Tools/QueueStatusServer/handlers/updatestatus.py (140785 => 140786)
--- trunk/Tools/QueueStatusServer/handlers/updatestatus.py 2013-01-25 06:57:41 UTC (rev 140785)
+++ trunk/Tools/QueueStatusServer/handlers/updatestatus.py 2013-01-25 07:00:11 UTC (rev 140786)
@@ -67,5 +67,4 @@
RecordBotEvent.record_activity(queue_status.queue_name, queue_status.bot_id)
if queue_status.active_patch_id:
RecordPatchEvent.updated(queue_status.active_patch_id, queue_status.queue_name, queue_status.bot_id)
- Attachment.dirty(queue_status.active_patch_id)
self.response.out.write(queue_status.key().id())
Modified: trunk/Tools/QueueStatusServer/model/attachment.py (140785 => 140786)
--- trunk/Tools/QueueStatusServer/model/attachment.py 2013-01-25 06:57:41 UTC (rev 140785)
+++ trunk/Tools/QueueStatusServer/model/attachment.py 2013-01-25 07:00:11 UTC (rev 140786)
@@ -28,8 +28,6 @@
import re
-from google.appengine.api import memcache
-
from model.queues import Queue
from model.queuestatus import QueueStatus
from model.workitems import WorkItems
@@ -37,10 +35,6 @@
class Attachment(object):
@classmethod
- def dirty(cls, attachment_id):
- memcache.delete(str(attachment_id), namespace="attachment-summary")
-
- @classmethod
def recent(cls, limit=1):
statuses = QueueStatus.all().order("-date")
# Notice that we use both a set and a list here to keep the -date ordering.
@@ -66,11 +60,7 @@
def summary(self):
if self._summary:
return self._summary
- self._summary = memcache.get(str(self.id), namespace="attachment-summary")
- if self._summary:
- return self._summary
self._summary = self._fetch_summary()
- memcache.set(str(self.id), self._summary, namespace="attachment-summary")
return self._summary
def state_from_queue_status(self, status):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
